diff options
author | dhollowa@chromium.org <dhollowa@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-05-14 23:04:37 +0000 |
---|---|---|
committer | dhollowa@chromium.org <dhollowa@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-05-14 23:04:37 +0000 |
commit | c59639d537a6a54a79ca0f831306ed58b785c908 (patch) | |
tree | bb2b5f7bfa5ad465e020d7feb9ab7b72bc3bf534 /chrome/browser/autofill/personal_data_manager.cc | |
parent | d344e9c1d44e0f6d717fd90ef67eabba1c2b65b9 (diff) | |
download | chromium_src-c59639d537a6a54a79ca0f831306ed58b785c908.zip chromium_src-c59639d537a6a54a79ca0f831306ed58b785c908.tar.gz chromium_src-c59639d537a6a54a79ca0f831306ed58b785c908.tar.bz2 |
AutoFill filling billing address and company name from profile.
The lego.com page represents a couple different issues. (1) is that the address fields are identified as billing address fields. So when filling from a profile and not a credit card those fields did not get filled. Based on discussion with Jeff Chang we're changing this so that when filling a profile, billing fields get treated as normal address fields and will be filled. In the code the distinction of billing versus "home" address information has now been removed as it is no longer applicable. (2) Company fields now get heuristically matched and filled.
BUG=40683
TEST=Manual testing of https://shop.lego.com/Checkout/Address/, \
Unit tests: AddressFieldTest.ParseCompany, AddressFieldTest.ParseCompanyEcml \
FormStructureTest.HeuristicsWithBilling FormStructureTest.HeuristicsSample6
Review URL: http://codereview.chromium.org/2085006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47331 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/browser/autofill/personal_data_manager.cc')
-rw-r--r-- | chrome/browser/autofill/personal_data_manager.cc | 3 |
1 files changed, 0 insertions, 3 deletions
diff --git a/chrome/browser/autofill/personal_data_manager.cc b/chrome/browser/autofill/personal_data_manager.cc index 073009ec..7e9b8e0 100644 --- a/chrome/browser/autofill/personal_data_manager.cc +++ b/chrome/browser/autofill/personal_data_manager.cc @@ -201,9 +201,6 @@ bool PersonalDataManager::ImportFormData( if (importable_fields + importable_credit_card_fields < kMinImportSize) return false; - if (!billing_address_info) - imported_profile_->set_use_billing_address(false); - if (importable_fields == 0) imported_profile_.reset(); |