diff options
| author | isherman@chromium.org <isherman@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2013-01-03 12:30:03 +0000 |
|---|---|---|
| committer | isherman@chromium.org <isherman@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2013-01-03 12:30:03 +0000 |
| commit | ddbda503787a8c88e8ae6db16b62fed2c19d9c52 (patch) | |
| tree | 221ae0a85524b13be1b06d5bafd1dec28d4d6a79 /chrome/browser/autofill | |
| parent | 6388d85e3b14801ccc0b8c7b3a66850b7d85d296 (diff) | |
| download | chromium_src-ddbda503787a8c88e8ae6db16b62fed2c19d9c52.zip chromium_src-ddbda503787a8c88e8ae6db16b62fed2c19d9c52.tar.gz chromium_src-ddbda503787a8c88e8ae6db16b62fed2c19d9c52.tar.bz2 | |
[Autofill] Clear the previewed fields whenever the popup is closed.
Because HideInternal() now might issue a call to the |delegate_|, we cannot NULL out the delegate_ prior to calling into the method. On the other hand, because HideInternal() can immediately call "delete this", we also cannot NULL out the delegate after calling into the method so as to affect the destructor's behavior. Hence, the extra boolean for tracking whether the delegate needs to be informed of the controller's deletion.
BUG=167830
Review URL: https://chromiumcodereview.appspot.com/11704004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@174954 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/browser/autofill')
| -rw-r--r-- | chrome/browser/autofill/autofill_external_delegate.cc | 3 |
1 files changed, 0 insertions, 3 deletions
diff --git a/chrome/browser/autofill/autofill_external_delegate.cc b/chrome/browser/autofill/autofill_external_delegate.cc index ad27460..6281ee9 100644 --- a/chrome/browser/autofill/autofill_external_delegate.cc +++ b/chrome/browser/autofill/autofill_external_delegate.cc @@ -265,7 +265,6 @@ void AutofillExternalDelegate::ControllerDestroyed() { void AutofillExternalDelegate::HideAutofillPopup() { if (controller_) { - ClearPreviewedForm(); controller_->Hide(); // Go ahead and invalidate |controller_|. After calling Hide(), it won't // inform |this| of its destruction. @@ -412,5 +411,3 @@ void AutofillExternalDelegate::Observe( NOTREACHED(); } } - - |