diff options
author | dcheng@chromium.org <dcheng@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2013-04-09 05:45:17 +0000 |
---|---|---|
committer | dcheng@chromium.org <dcheng@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2013-04-09 05:45:17 +0000 |
commit | e59558b78e8c6a1b0bd916a724724b638c3c91b6 (patch) | |
tree | 712268a7e9e1cd552f309d89641b2bed5ad06322 /chrome/browser/autofill | |
parent | 31fcd34da3797bc49160620ef8c94a38652c0587 (diff) | |
download | chromium_src-e59558b78e8c6a1b0bd916a724724b638c3c91b6.zip chromium_src-e59558b78e8c6a1b0bd916a724724b638c3c91b6.tar.gz chromium_src-e59558b78e8c6a1b0bd916a724724b638c3c91b6.tar.bz2 |
Rewrite std::string("") to std::string(), Linux edition.
This patch was generated by running the empty_string clang tool
across the Chromium Linux compilation database. Implicitly or
explicitly constructing std::string() with a "" argument is
inefficient as the caller needs to emit extra instructions to
pass an argument, and the constructor needlessly copies a byte
into internal storage. Rewriting these instances to simply call
the default constructor appears to save ~14-18 kilobytes on an
optimized release build.
BUG=none
Review URL: https://codereview.chromium.org/13145003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@193020 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/browser/autofill')
-rw-r--r-- | chrome/browser/autofill/autofill_browsertest.cc | 24 |
1 files changed, 12 insertions, 12 deletions
diff --git a/chrome/browser/autofill/autofill_browsertest.cc b/chrome/browser/autofill/autofill_browsertest.cc index af63f86..b3d6f54 100644 --- a/chrome/browser/autofill/autofill_browsertest.cc +++ b/chrome/browser/autofill/autofill_browsertest.cc @@ -505,14 +505,14 @@ class AutofillTest : public InProcessBrowserTest { // The previewed values should not be accessible to JavaScript. ExpectFieldValue("firstname", "M"); - ExpectFieldValue("lastname", ""); - ExpectFieldValue("address1", ""); - ExpectFieldValue("address2", ""); - ExpectFieldValue("city", ""); - ExpectFieldValue("state", ""); - ExpectFieldValue("zip", ""); - ExpectFieldValue("country", ""); - ExpectFieldValue("phone", ""); + ExpectFieldValue("lastname", std::string()); + ExpectFieldValue("address1", std::string()); + ExpectFieldValue("address2", std::string()); + ExpectFieldValue("city", std::string()); + ExpectFieldValue("state", std::string()); + ExpectFieldValue("zip", std::string()); + ExpectFieldValue("country", std::string()); + ExpectFieldValue("phone", std::string()); // TODO(isherman): It would be nice to test that the previewed values are // displayed: http://crbug.com/57220 @@ -742,7 +742,7 @@ IN_PROC_BROWSER_TEST_F(AutofillTest, DISABLED_AutofillFormWithRepeatedField) { // Invoke Autofill. TryBasicFormFill(); - ExpectFieldValue("state_freeform", ""); + ExpectFieldValue("state_freeform", std::string()); } // http://crbug.com/150084 @@ -1307,8 +1307,8 @@ IN_PROC_BROWSER_TEST_F(AutofillTest, MAYBE_ComparePhoneNumbers) { ExpectFieldValue("PHONE_HOME_NUMBER_3-2", "555"); ExpectFieldValue("PHONE_HOME_NUMBER_4-1", "4567"); ExpectFieldValue("PHONE_HOME_NUMBER_4-2", "4567"); - ExpectFieldValue("PHONE_HOME_EXT-1", ""); - ExpectFieldValue("PHONE_HOME_EXT-2", ""); + ExpectFieldValue("PHONE_HOME_EXT-1", std::string()); + ExpectFieldValue("PHONE_HOME_EXT-2", std::string()); ExpectFieldValue("PHONE_HOME_COUNTRY_CODE-1", "1"); } @@ -1447,7 +1447,7 @@ IN_PROC_BROWSER_TEST_F(AutofillTest, MAYBE_NoAutofillForReadOnlyFields) { ui_test_utils::NavigateToURL(browser(), url); PopulateForm("firstname"); - ExpectFieldValue("email", ""); + ExpectFieldValue("email", std::string()); ExpectFieldValue("address", addr_line1); } |