diff options
| author | ananta@chromium.org <ananta@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-07-28 23:04:09 +0000 |
|---|---|---|
| committer | ananta@chromium.org <ananta@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-07-28 23:04:09 +0000 |
| commit | d1bd3527b5fc700e358b1f07d2c5541280db188c (patch) | |
| tree | 270e6223927ac74a34711483c7179721f2a8f5d2 /chrome/browser/automation/ui_controls_mac.mm | |
| parent | d1b0633fad3ac53db789e4324cc0c37821e9694a (diff) | |
| download | chromium_src-d1bd3527b5fc700e358b1f07d2c5541280db188c.zip chromium_src-d1bd3527b5fc700e358b1f07d2c5541280db188c.tar.gz chromium_src-d1bd3527b5fc700e358b1f07d2c5541280db188c.tar.bz2 | |
Merge 53786 - Our InPlaceMenu implementation is only partially being used.
We had a leftover call to InPlaceMenuDestroy without creating a menu in the first place.
This caused us to delete IE's menu and fail the first check inside ieframe!CDocObjectHost::OnInitMenuPopup.
It took a while to figure this out and even longer to figure out why our menu was NULL in this case and not mshtml's.
I don't think that there are any bad side effects with this change but I ask the reviewer to check.
The visible change is that the Print menu item will become enabled and visible whereas Page Setup will be disabled and Print Preview will (correctly atm) not be visible for GCF documents.
BUG=24034, 47074
TEST=See description above and bug report.
Review URL: http://codereview.chromium.org/3034033
TBR=tommi@chromium.org
Review URL: http://codereview.chromium.org/2836074
git-svn-id: svn://svn.chromium.org/chrome/branches/472/src@54063 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/browser/automation/ui_controls_mac.mm')
0 files changed, 0 insertions, 0 deletions