diff options
author | jam@chromium.org <jam@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2012-01-03 05:53:20 +0000 |
---|---|---|
committer | jam@chromium.org <jam@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2012-01-03 05:53:20 +0000 |
commit | 4ca153033f022dc6e11d6094daed41b1ed0a995f (patch) | |
tree | f4720517b10953166f84707ca3ec8b82de860884 /chrome/browser/bookmarks/bookmark_utils.cc | |
parent | 08bd3d71d969061b1588e6a4210f6d74b0ec0c6d (diff) | |
download | chromium_src-4ca153033f022dc6e11d6094daed41b1ed0a995f.zip chromium_src-4ca153033f022dc6e11d6094daed41b1ed0a995f.tar.gz chromium_src-4ca153033f022dc6e11d6094daed41b1ed0a995f.tar.bz2 |
Replace most of Browser::GetSelectedTabContents calls into Browser::GetSelectedWebContents. I've converted the easy ones, I'll do the ones with more dependencies in a separate change to keep things trivial to review.
I considered taking out GetSelectedTabContents altogether and having people just use GetSelectedTabContentsWrapper()->web_contents() per the existing comment in browser.h, but there are a lot of callers and it seemed too long to type.
BUG=98716
TBR=joi
Review URL: http://codereview.chromium.org/9015022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@116122 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/browser/bookmarks/bookmark_utils.cc')
-rw-r--r-- | chrome/browser/bookmarks/bookmark_utils.cc | 18 |
1 files changed, 9 insertions, 9 deletions
diff --git a/chrome/browser/bookmarks/bookmark_utils.cc b/chrome/browser/bookmarks/bookmark_utils.cc index 62cc9c7..dae8644 100644 --- a/chrome/browser/bookmarks/bookmark_utils.cc +++ b/chrome/browser/bookmarks/bookmark_utils.cc @@ -157,7 +157,7 @@ void OpenAllImpl(const BookmarkNode* node, // the current page, reset the navigator just to be sure. Browser* new_browser = BrowserList::GetLastActiveWithProfile(profile); if (new_browser) { - TabContents* current_tab = new_browser->GetSelectedTabContents(); + WebContents* current_tab = new_browser->GetSelectedWebContents(); DCHECK(new_browser && current_tab); if (new_browser && current_tab) *navigator = current_tab; @@ -385,14 +385,14 @@ void OpenAll(gfx::NativeWindow parent, NewBrowserPageNavigator navigator_impl(profile); if (!navigator) { Browser* browser = BrowserList::FindTabbedBrowser(profile, false); - if (!browser || !browser->GetSelectedTabContents()) { + if (!browser || !browser->GetSelectedWebContents()) { navigator = &navigator_impl; } else { if (initial_disposition != NEW_WINDOW && initial_disposition != OFF_THE_RECORD) { browser->window()->Activate(); } - navigator = browser->GetSelectedTabContents(); + navigator = browser->GetSelectedWebContents(); } } @@ -652,21 +652,21 @@ void RegisterUserPrefs(PrefService* prefs) { PrefService::UNSYNCABLE_PREF); } -void GetURLAndTitleToBookmark(TabContents* tab_contents, +void GetURLAndTitleToBookmark(WebContents* web_contents, GURL* url, string16* title) { - *url = tab_contents->GetURL(); - *title = tab_contents->GetTitle(); + *url = web_contents->GetURL(); + *title = web_contents->GetTitle(); } void GetURLAndTitleToBookmarkFromCurrentTab(Profile* profile, GURL* url, string16* title) { Browser* browser = BrowserList::GetLastActiveWithProfile(profile); - TabContents* tab_contents = browser ? browser->GetSelectedTabContents() + WebContents* web_contents = browser ? browser->GetSelectedWebContents() : NULL; - if (tab_contents) - GetURLAndTitleToBookmark(tab_contents, url, title); + if (web_contents) + GetURLAndTitleToBookmark(web_contents, url, title); } void GetURLsForOpenTabs( |