diff options
| author | yosin@chromium.org <yosin@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2012-11-16 08:41:05 +0000 |
|---|---|---|
| committer | yosin@chromium.org <yosin@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2012-11-16 08:41:05 +0000 |
| commit | 872275966d385ee8c26748c84f222e078f915f9c (patch) | |
| tree | 7eeaff6a3ca55ba3e131c9d7090ee12341f0a26b /chrome/browser/bookmarks | |
| parent | 2b259f00deb9a2db8af480d5ce773a5d114756ef (diff) | |
| download | chromium_src-872275966d385ee8c26748c84f222e078f915f9c.zip chromium_src-872275966d385ee8c26748c84f222e078f915f9c.tar.gz chromium_src-872275966d385ee8c26748c84f222e078f915f9c.tar.bz2 | |
This patch changes participation condition of bookmark prompt experiment to:
- 1% of new users on Canary channel
- One month
rather than using variations service.
Checking new user, aka new installation, is as same as
https://chromiumcodereview.appspot.com/11363062
We'll change the start date for stable channel once it is fixed.
BUG=160151
Review URL: https://chromiumcodereview.appspot.com/11412002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@168170 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/browser/bookmarks')
| -rw-r--r-- | chrome/browser/bookmarks/bookmark_prompt_prefs.cc | 15 |
1 files changed, 1 insertions, 14 deletions
diff --git a/chrome/browser/bookmarks/bookmark_prompt_prefs.cc b/chrome/browser/bookmarks/bookmark_prompt_prefs.cc index b372645..ca63066 100644 --- a/chrome/browser/bookmarks/bookmark_prompt_prefs.cc +++ b/chrome/browser/bookmarks/bookmark_prompt_prefs.cc @@ -4,23 +4,11 @@ #include "chrome/browser/bookmarks/bookmark_prompt_prefs.h" -#include "base/metrics/field_trial.h" #include "base/prefs/public/pref_service_base.h" #include "chrome/common/pref_names.h" namespace { -// This function checks field trial "BookmarkPrompt" managed by -// VariationsService. -bool IsBookmarkFieldTrialActive() { - base::FieldTrial* trial = base::FieldTrialList::Find("BookmarkPrompt"); - if (!trial) { - DVLOG(1) << "BookmarkPrompt field trial was not found."; - return false; - } - return trial->group_name() == "V1"; -} - } // namespace BookmarkPromptPrefs::BookmarkPromptPrefs(PrefServiceBase* user_prefs) @@ -44,8 +32,7 @@ void BookmarkPromptPrefs::IncrementPromptImpressionCount() { } bool BookmarkPromptPrefs::IsBookmarkPromptEnabled() const { - return prefs_->GetBoolean(prefs::kBookmarkPromptEnabled) && - IsBookmarkFieldTrialActive(); + return prefs_->GetBoolean(prefs::kBookmarkPromptEnabled); } // static |