diff options
author | evan@chromium.org <evan@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-11-17 19:04:12 +0000 |
---|---|---|
committer | evan@chromium.org <evan@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-11-17 19:04:12 +0000 |
commit | afe3a16739185a648a21a34e07f3cdb5f1a23c2f (patch) | |
tree | 4c82ce550948ed3d67a7a46a1aa066c9080412fb /chrome/browser/bookmarks | |
parent | d699e3a52d6431ea5d2a691f77866ac8ec7ba350 (diff) | |
download | chromium_src-afe3a16739185a648a21a34e07f3cdb5f1a23c2f.zip chromium_src-afe3a16739185a648a21a34e07f3cdb5f1a23c2f.tar.gz chromium_src-afe3a16739185a648a21a34e07f3cdb5f1a23c2f.tar.bz2 |
Use plain strings instead of wstrings for UMA actions
git grep 'RecordAction(L' | xargs sed -i -e s/RecordAction(L/RecordAction(/
This cuts more than 10k off my binary. Which is nothing compared
to the size of the binary, but that's a whole lot of zero bytes!
This is less code this way anyway.
Review URL: http://codereview.chromium.org/399026
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32194 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/browser/bookmarks')
-rw-r--r-- | chrome/browser/bookmarks/bookmark_context_menu_controller.cc | 24 |
1 files changed, 12 insertions, 12 deletions
diff --git a/chrome/browser/bookmarks/bookmark_context_menu_controller.cc b/chrome/browser/bookmarks/bookmark_context_menu_controller.cc index 0e62277..ed7784b 100644 --- a/chrome/browser/bookmarks/bookmark_context_menu_controller.cc +++ b/chrome/browser/bookmarks/bookmark_context_menu_controller.cc @@ -285,16 +285,16 @@ void BookmarkContextMenuController::ExecuteCommand(int id) { WindowOpenDisposition initial_disposition; if (id == IDS_BOOMARK_BAR_OPEN_ALL) { initial_disposition = NEW_FOREGROUND_TAB; - UserMetrics::RecordAction(L"BookmarkBar_ContextMenu_OpenAll", + UserMetrics::RecordAction("BookmarkBar_ContextMenu_OpenAll", profile_); } else if (id == IDS_BOOMARK_BAR_OPEN_ALL_NEW_WINDOW) { initial_disposition = NEW_WINDOW; - UserMetrics::RecordAction( - L"BookmarkBar_ContextMenu_OpenAllInNewWindow", profile_); + UserMetrics::RecordAction("BookmarkBar_ContextMenu_OpenAllInNewWindow", + profile_); } else { initial_disposition = OFF_THE_RECORD; - UserMetrics::RecordAction( - L"BookmarkBar_ContextMenu_OpenAllIncognito", profile_); + UserMetrics::RecordAction("BookmarkBar_ContextMenu_OpenAllIncognito", + profile_); } bookmark_utils::OpenAll(parent_window_, profile_, navigator_, selection_, initial_disposition); @@ -303,7 +303,7 @@ void BookmarkContextMenuController::ExecuteCommand(int id) { case IDS_BOOKMARK_BAR_RENAME_FOLDER: case IDS_BOOKMARK_BAR_EDIT: - UserMetrics::RecordAction(L"BookmarkBar_ContextMenu_Edit", profile_); + UserMetrics::RecordAction("BookmarkBar_ContextMenu_Edit", profile_); if (selection_.size() != 1) { NOTREACHED(); @@ -326,7 +326,7 @@ void BookmarkContextMenuController::ExecuteCommand(int id) { break; case IDS_BOOKMARK_BAR_REMOVE: { - UserMetrics::RecordAction(L"BookmarkBar_ContextMenu_Remove", profile_); + UserMetrics::RecordAction("BookmarkBar_ContextMenu_Remove", profile_); BookmarkModel* model = RemoveModelObserver(); for (size_t i = 0; i < selection_.size(); ++i) { @@ -338,7 +338,7 @@ void BookmarkContextMenuController::ExecuteCommand(int id) { } case IDS_BOOMARK_BAR_ADD_NEW_BOOKMARK: { - UserMetrics::RecordAction(L"BookmarkBar_ContextMenu_Add", profile_); + UserMetrics::RecordAction("BookmarkBar_ContextMenu_Add", profile_); BookmarkEditor::Configuration editor_config; BookmarkEditor::Handler* handler = NULL; @@ -356,7 +356,7 @@ void BookmarkContextMenuController::ExecuteCommand(int id) { } case IDS_BOOMARK_BAR_NEW_FOLDER: { - UserMetrics::RecordAction(L"BookmarkBar_ContextMenu_NewFolder", + UserMetrics::RecordAction("BookmarkBar_ContextMenu_NewFolder", profile_); EditFolderController::Show(profile_, parent_window_, GetParentForNewNodes(), true, @@ -369,7 +369,7 @@ void BookmarkContextMenuController::ExecuteCommand(int id) { break; case IDS_BOOKMARK_MANAGER_SHOW_IN_FOLDER: - UserMetrics::RecordAction(L"BookmarkBar_ContextMenu_ShowInFolder", + UserMetrics::RecordAction("BookmarkBar_ContextMenu_ShowInFolder", profile_); if (selection_.size() != 1) { @@ -381,12 +381,12 @@ void BookmarkContextMenuController::ExecuteCommand(int id) { break; case IDS_BOOKMARK_MANAGER: - UserMetrics::RecordAction(L"ShowBookmarkManager", profile_); + UserMetrics::RecordAction("ShowBookmarkManager", profile_); BookmarkManager::Show(profile_); break; case IDS_BOOKMARK_MANAGER_SORT: - UserMetrics::RecordAction(L"BookmarkManager_Sort", profile_); + UserMetrics::RecordAction("BookmarkManager_Sort", profile_); model_->SortChildren(parent_); break; |