diff options
| author | erikkay@google.com <erikkay@google.com@0039d316-1c4b-4281-b951-d872f2087c98> | 2008-08-06 22:33:53 +0000 |
|---|---|---|
| committer | erikkay@google.com <erikkay@google.com@0039d316-1c4b-4281-b951-d872f2087c98> | 2008-08-06 22:33:53 +0000 |
| commit | b63cbfaf62c1119b1f4b715d0186e516a2444600 (patch) | |
| tree | b6e7fbb8c61210ccabd4aecb4a152fdf49c371b1 /chrome/browser/browser_about_handler.cc | |
| parent | bce65f6127c9d190c9da6948a3ef494f93a69a02 (diff) | |
| download | chromium_src-b63cbfaf62c1119b1f4b715d0186e516a2444600.zip chromium_src-b63cbfaf62c1119b1f4b715d0186e516a2444600.tar.gz chromium_src-b63cbfaf62c1119b1f4b715d0186e516a2444600.tar.bz2 | |
* add webkit version and V8 version to about:version
* reformat page
* use new product image rather than an http link to google.com
BUG=1300256
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@465 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/browser/browser_about_handler.cc')
| -rw-r--r-- | chrome/browser/browser_about_handler.cc | 17 |
1 files changed, 17 insertions, 0 deletions
diff --git a/chrome/browser/browser_about_handler.cc b/chrome/browser/browser_about_handler.cc index fca4e8d..3dd1ee0 100644 --- a/chrome/browser/browser_about_handler.cc +++ b/chrome/browser/browser_about_handler.cc @@ -62,6 +62,9 @@ #include "chrome/renderer/about_handler.h" #include "googleurl/src/gurl.h" #include "webkit/glue/webkit_glue.h" +#ifdef CHROME_V8 +#include "v8/public/v8.h" +#endif #include "generated_resources.h" @@ -254,9 +257,23 @@ std::string BrowserAboutHandler::AboutVersion() { DLOG(ERROR) << "Unable to create FileVersionInfo object"; return std::string(); } + + std::wstring webkit_version = UTF8ToWide(webkit_glue::GetWebKitVersion()); +#ifdef CHROME_V8 + const char* v8_vers = v8::V8::GetVersion(); + std::wstring js_version = UTF8ToWide(v8_vers); + std::wstring js_engine = L"V8"; +#else + std::wstring js_version = webkit_version; + std::wstring js_engine = L"JavaScriptCore"; +#endif + localized_strings.SetString(L"name", l10n_util::GetString(IDS_PRODUCT_NAME)); localized_strings.SetString(L"version", version_info->file_version()); + localized_strings.SetString(L"js_engine", js_engine); + localized_strings.SetString(L"js_version", js_version); + localized_strings.SetString(L"webkit_version", webkit_version); localized_strings.SetString(L"company", l10n_util::GetString(IDS_ABOUT_VERSION_COMPANY_NAME)); localized_strings.SetString(L"copyright", |