diff options
| author | phajdan.jr@chromium.org <phajdan.jr@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2012-12-21 22:48:09 +0000 |
|---|---|---|
| committer | phajdan.jr@chromium.org <phajdan.jr@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2012-12-21 22:48:09 +0000 |
| commit | 1e09ec8405edea095b9c1a064197d44098a02620 (patch) | |
| tree | 3ccc095a457a6b1d46f1881f72e338ce7f46dc4b /chrome/browser/browser_keyevents_browsertest.cc | |
| parent | 688c779b257790393623cbce64734e979d5eb675 (diff) | |
| download | chromium_src-1e09ec8405edea095b9c1a064197d44098a02620.zip chromium_src-1e09ec8405edea095b9c1a064197d44098a02620.tar.gz chromium_src-1e09ec8405edea095b9c1a064197d44098a02620.tar.bz2 | |
GTTF: No more FLAKY_ .
Please note that FLAKY_ tests have been ignored anyway. When tests started
crashing, people just flipped that to DISABLED_ . Why not go straight to
DISABLED_ then, so that we avoid wasting time on stupid test prefix games?
With DISABLED_ it is clear to everyone that there is no coverage from given
test. FLAKY_ creates an illusion of coverage, while in fact the test is still
ignored.
If a FLAKY_ test fails and nobody notices, does it still make a sound? ;-)
Finally, note that gtest has a --gtest_also_run_disabled_tests if you need
to run tests manually.
TBR=jam
BUG=none
Review URL: https://codereview.chromium.org/11664013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@174472 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/browser/browser_keyevents_browsertest.cc')
| -rw-r--r-- | chrome/browser/browser_keyevents_browsertest.cc | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/chrome/browser/browser_keyevents_browsertest.cc b/chrome/browser/browser_keyevents_browsertest.cc index 5381581..dab20b0 100644 --- a/chrome/browser/browser_keyevents_browsertest.cc +++ b/chrome/browser/browser_keyevents_browsertest.cc @@ -806,7 +806,7 @@ IN_PROC_BROWSER_TEST_F(BrowserKeyEventsTest, EditorKeyBindings) { #endif // See http://crbug.com/147579 -IN_PROC_BROWSER_TEST_F(BrowserKeyEventsTest, FLAKY_PageUpDownKeys) { +IN_PROC_BROWSER_TEST_F(BrowserKeyEventsTest, DISABLED_PageUpDownKeys) { static const KeyEventTestData kTestPageUp = { ui::VKEY_PRIOR, false, false, false, false, false, false, false, false, 2, |