summaryrefslogtreecommitdiffstats
path: root/chrome/browser/browser_process.h
diff options
context:
space:
mode:
authortzik@chromium.org <tzik@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2014-06-03 04:40:18 +0000
committertzik@chromium.org <tzik@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2014-06-03 04:40:18 +0000
commit690d3e34dcdd4dfcac08eeafe654bb86889db80b (patch)
treeb5891acbc07ea2eeb25a042c0118ca921481a4e6 /chrome/browser/browser_process.h
parentde46a6d6c3d5298cc0da6fa8cc1c1ca596ff79ef (diff)
downloadchromium_src-690d3e34dcdd4dfcac08eeafe654bb86889db80b.zip
chromium_src-690d3e34dcdd4dfcac08eeafe654bb86889db80b.tar.gz
chromium_src-690d3e34dcdd4dfcac08eeafe654bb86889db80b.tar.bz2
Revert of Reduce plugin_metrics_provider_ usage in MetricsService (https://codereview.chromium.org/308433004/)
Reason for revert: This CL seems to cause bot failure on CI: http://build.chromium.org/p/chromium.memory/builders/Linux%20ASan%20LSan%20Tests%20%281%29/builds/2745 Original issue's description: > Reduce plugin_metrics_provider_ usage in MetricsService > > This CL eliminates MetricsService's call to > PluginMetricsProvider::RecordPluginChanges (replaced by a new API on > MetricsProvider). It additionally adds a > MetricsServicesManager::OnPluginLoadingError() API and has the plugin observer > call that API rather than calling MetricsService directly. This change will > enable easily moving MetricsService::LogPluginLoadingError() to > ChromeMetricsServiceClient once the latter is the class that keeps a weak > pointer to the plugin metrics provider. > > BUG=375776 > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=274403 TBR=asvitkine@chromium.org,isherman@chromium.org,jochen@chromium.org,blundell@chromium.org NOTREECHECKS=true NOTRY=true BUG=375776 Review URL: https://codereview.chromium.org/314583002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274418 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/browser/browser_process.h')
-rw-r--r--chrome/browser/browser_process.h5
1 files changed, 0 insertions, 5 deletions
diff --git a/chrome/browser/browser_process.h b/chrome/browser/browser_process.h
index cda9e23..8e46d93 100644
--- a/chrome/browser/browser_process.h
+++ b/chrome/browser/browser_process.h
@@ -29,7 +29,6 @@ class IntranetRedirectDetector;
class IOThread;
class MediaFileSystemRegistry;
class MetricsService;
-class MetricsServicesManager;
class NetworkTimeTracker;
class NotificationUIManager;
class PrefRegistrySimple;
@@ -103,10 +102,6 @@ class BrowserProcess {
// continue shutdown.
virtual void EndSession() = 0;
- // Gets the manager for the various metrics-related services, constructing it
- // if necessary.
- virtual MetricsServicesManager* GetMetricsServicesManager() = 0;
-
// Services: any of these getters may return NULL
virtual MetricsService* metrics_service() = 0;
virtual rappor::RapporService* rappor_service() = 0;