diff options
| author | pkasting@chromium.org <pkasting@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-10-13 01:40:30 +0000 |
|---|---|---|
| committer | pkasting@chromium.org <pkasting@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-10-13 01:40:30 +0000 |
| commit | fd9c35f41bcab4966a5db8d24de812b1e9f87967 (patch) | |
| tree | e896d02bd840995415ce362ff498c460f14e6601 /chrome/browser/browser_theme_provider.h | |
| parent | 28fe69ab1bb9362a1ee105821ec4631b574417d3 (diff) | |
| download | chromium_src-fd9c35f41bcab4966a5db8d24de812b1e9f87967.zip chromium_src-fd9c35f41bcab4966a5db8d24de812b1e9f87967.tar.gz chromium_src-fd9c35f41bcab4966a5db8d24de812b1e9f87967.tar.bz2 | |
Misc. cleanup for theme provider code, including:
* Use correct indentation/alignment in a number of places
* Use early-return to avoid long code block indenting
* Use for() instead of while() in cases where that's what the code is actually doing
* Consistent naming for iterators ("foo_iter", "bar_iter" instead of sometimes that way and sometimes "found")
* Use {} when needed, don't use when not
* Do not use "else" after "return"
* Shorten overly-verbose code
* Pull some trivial functions into the header
* Eliminate unused function
* Use STLDeleteValues() helper where appropriate
Some of this was originally in my patch that modified constness, but I've split it out to make that more sane.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/272033
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28771 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/browser/browser_theme_provider.h')
| -rw-r--r-- | chrome/browser/browser_theme_provider.h | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/chrome/browser/browser_theme_provider.h b/chrome/browser/browser_theme_provider.h index 0d3524b..a89c764 100644 --- a/chrome/browser/browser_theme_provider.h +++ b/chrome/browser/browser_theme_provider.h @@ -301,8 +301,8 @@ class BrowserThemeProvider : public NonThreadSafe, // Allow any ResourceBundle image to be overridden. |images| should // contain keys defined in ThemeResourceMap, and values as paths to // the images on-disk. - void SetImageData(DictionaryValue* images, - FilePath images_path); + void SetImageData(DictionaryValue* images, FilePath images_path); + // Set our theme colors. The keys of |colors| are any of the kColor* // constants, and the values are a three-item list containing 8-bit // RGB values. |