diff options
| author | jsbell <jsbell@chromium.org> | 2015-08-25 11:55:43 -0700 |
|---|---|---|
| committer | Commit bot <commit-bot@chromium.org> | 2015-08-25 18:56:20 +0000 |
| commit | 81f54d7a8cd88c5a8a7e40c858bf342eec68d6ab (patch) | |
| tree | 755573e30890e59b94c43fe3cbb4b9aa1b8e40f9 /chrome/browser/browsing_data/mock_browsing_data_appcache_helper.h | |
| parent | 289d1f6ba870b30cbf4a19d114b2ee4fc23f893f (diff) | |
| download | chromium_src-81f54d7a8cd88c5a8a7e40c858bf342eec68d6ab.zip chromium_src-81f54d7a8cd88c5a8a7e40c858bf342eec68d6ab.tar.gz chromium_src-81f54d7a8cd88c5a8a7e40c858bf342eec68d6ab.tar.bz2 | |
Simplify browsing data helpers for storage types
The BrowsingDataXXXHelper classes are used by chrome/ to query
content/ for the usage (origins, sizes, last modified times, etc) of
various storage types (cookies, local storage, indexed db, etc). These
helpers followed a pattern of storing local state (`is_fetching_`) the
results (`xxx_info_`) and continuation (`calllback_`) while thread
hopping (UI->IO->UI) and asynchronously querying.
Simplify the classes by passing the information along in closures and
eliminate relay methods where possible. Also, simplify some of the
content/public struct definitions these helpers consume.
(The Quota and AppCache helpers are more complex and will be tackled later.)
BUG=524222
Review URL: https://codereview.chromium.org/1310273003
Cr-Commit-Position: refs/heads/master@{#345397}
Diffstat (limited to 'chrome/browser/browsing_data/mock_browsing_data_appcache_helper.h')
| -rw-r--r-- | chrome/browser/browsing_data/mock_browsing_data_appcache_helper.h | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/chrome/browser/browsing_data/mock_browsing_data_appcache_helper.h b/chrome/browser/browsing_data/mock_browsing_data_appcache_helper.h index 917ce34..0246ffd 100644 --- a/chrome/browser/browsing_data/mock_browsing_data_appcache_helper.h +++ b/chrome/browser/browsing_data/mock_browsing_data_appcache_helper.h @@ -14,7 +14,7 @@ class MockBrowsingDataAppCacheHelper explicit MockBrowsingDataAppCacheHelper( content::BrowserContext* browser_context); - void StartFetching(const base::Closure& completion_callback) override; + void StartFetching(const FetchCallback& completion_callback) override; void DeleteAppCacheGroup(const GURL& manifest_url) override; private: |