diff options
author | pkasting@chromium.org <pkasting@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-09-16 21:33:45 +0000 |
---|---|---|
committer | pkasting@chromium.org <pkasting@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-09-16 21:33:45 +0000 |
commit | 4a879f60ee8a75b1e6a2d9456d6fe762e87bb70d (patch) | |
tree | 01a08174fc6dd01100cfb80810dd5046d148cd55 /chrome/browser/bubble_positioner.h | |
parent | 665caa21cf5904f6935dfa6e091522206a8f05e9 (diff) | |
download | chromium_src-4a879f60ee8a75b1e6a2d9456d6fe762e87bb70d.zip chromium_src-4a879f60ee8a75b1e6a2d9456d6fe762e87bb70d.tar.gz chromium_src-4a879f60ee8a75b1e6a2d9456d6fe762e87bb70d.tar.bz2 |
Convert InfoBubble to using BubbleBorder. This also replaces the border graphics with a slightly darker set from Nicholas.
The downside here is that the Linux views code is definitely going to be broken by this. I'm not sure of the best design for Linux views, so I haven't implemented one.
BUG=21028
TEST=Open info bubbles (click star button, hover lock icon) and observe they are rendered with an identical border/shadow to the Omnibox dropdown, and at the same vertical position.
Review URL: http://codereview.chromium.org/195099
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26394 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/browser/bubble_positioner.h')
-rw-r--r-- | chrome/browser/bubble_positioner.h | 6 |
1 files changed, 4 insertions, 2 deletions
diff --git a/chrome/browser/bubble_positioner.h b/chrome/browser/bubble_positioner.h index 5336b1b..7ea4df0 100644 --- a/chrome/browser/bubble_positioner.h +++ b/chrome/browser/bubble_positioner.h @@ -10,12 +10,14 @@ class Rect; } // An object in the browser UI can implement this interface to provide display -// bounds for the omnibox bubble. +// bounds for the omnibox bubble and info bubble views. class BubblePositioner { public: // Returns the bounds of the "location bar" stack (including star/go buttons // where relevant). The omnibox dropdown uses this to calculate its width and - // y-coordinate. + // y-coordinate, and views showing InfoBubbles use it to find the y-coordinate + // they should show at, so that all "bubble" UIs show up at the same vertical + // position. virtual gfx::Rect GetLocationStackBounds() const = 0; }; |