summaryrefslogtreecommitdiffstats
path: root/chrome/browser/chrome_browser_field_trials.h
diff options
context:
space:
mode:
authormad@chromium.org <mad@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2013-03-26 21:38:15 +0000
committermad@chromium.org <mad@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2013-03-26 21:38:15 +0000
commita7c94bc9887ce9ab4afbaa7149b403db81940cac (patch)
treea2cc73c7560acb582769a4f78dfb3b5e18fa609c /chrome/browser/chrome_browser_field_trials.h
parent6c6361d31df0f6397092bba0659230bcad7ef88c (diff)
downloadchromium_src-a7c94bc9887ce9ab4afbaa7149b403db81940cac.zip
chromium_src-a7c94bc9887ce9ab4afbaa7149b403db81940cac.tar.gz
chromium_src-a7c94bc9887ce9ab4afbaa7149b403db81940cac.tar.bz2
Add a new App launcher promo to the apps page / NTP.
Simple change in chrome/browser/chrome_browser_main.cc TBR=ben@chromium.org BUG=180475 TEST=Make sure the apps promo only show on apps page of the NTP (or chrome://apps) and that it links to webstore (specific page to be added later on the webstore) and that it doesn't come back on a given installation of Chrome once dismissed with the X close button. That dimiss state can be reset with the command line switch --reset-show-apps-promo to help test it. Also, this shouldn't show when the App Launcher is installer... since no apps page should be shown anyway (tested with --show-app-list-shortcut) Review URL: https://chromiumcodereview.appspot.com/12985002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@190772 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/browser/chrome_browser_field_trials.h')
-rw-r--r--chrome/browser/chrome_browser_field_trials.h16
1 files changed, 11 insertions, 5 deletions
diff --git a/chrome/browser/chrome_browser_field_trials.h b/chrome/browser/chrome_browser_field_trials.h
index dc92241..bd0cf62 100644
--- a/chrome/browser/chrome_browser_field_trials.h
+++ b/chrome/browser/chrome_browser_field_trials.h
@@ -10,16 +10,16 @@
#include "base/gtest_prod_util.h"
#include "base/time.h"
+class PrefService;
+
class ChromeBrowserFieldTrials {
public:
explicit ChromeBrowserFieldTrials(const CommandLine& command_line);
~ChromeBrowserFieldTrials();
// Called by the browser main sequence to set up Field Trials for this client.
- // |install_time| is the time this browser was installed (or the last time
- // prefs was reset). |install_time| is used by trials that are only created
- // for new installs of the browser.
- void SetupFieldTrials(const base::Time& install_time);
+ // |local_state| is used to extract properties like install time.
+ void SetupFieldTrials(PrefService* local_state);
private:
FRIEND_TEST_ALL_PREFIXES(BrowserMainTest,
@@ -30,7 +30,13 @@ class ChromeBrowserFieldTrials {
// Sets up common desktop-only field trials.
// Add an invocation of your field trial init function to this method, or to
// SetupFieldTrials if it is for all platforms.
- void SetupDesktopFieldTrials();
+ // |local_state| is needed by some other methods called from within this one.
+ void SetupDesktopFieldTrials(PrefService* local_state);
+
+ // This is not quite a field trial initialization, but it's an initialization
+ // that depends on a field trial, so why not? :-)
+ // |local_state| is needed to reset a local pref based on the chosen group.
+ void SetupAppLauncherFieldTrial(PrefService* local_state);
// A/B test for spdy when --use-spdy not set.
void SpdyFieldTrial();