diff options
author | ajwong@chromium.org <ajwong@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2011-12-29 19:14:00 +0000 |
---|---|---|
committer | ajwong@chromium.org <ajwong@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2011-12-29 19:14:00 +0000 |
commit | 71cb8aa4fde2396b0fedd14cffc3e402f39547c4 (patch) | |
tree | da8b02ed68d792a4f1528085b34fe162664bb5c9 /chrome/browser/chromeos/boot_times_loader.cc | |
parent | d5dc80d56d967d3709fc4f11b9e0db2005a4eab3 (diff) | |
download | chromium_src-71cb8aa4fde2396b0fedd14cffc3e402f39547c4.zip chromium_src-71cb8aa4fde2396b0fedd14cffc3e402f39547c4.tar.gz chromium_src-71cb8aa4fde2396b0fedd14cffc3e402f39547c4.tar.bz2 |
Retry: Convert stragglers not on spreadsheet to base::Bind()
Original review: http://codereview.chromium.org/9035002/
BUG=none
TEST=try bots (including shared)
Review URL: http://codereview.chromium.org/9049012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@115976 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/browser/chromeos/boot_times_loader.cc')
-rw-r--r-- | chrome/browser/chromeos/boot_times_loader.cc | 12 |
1 files changed, 3 insertions, 9 deletions
diff --git a/chrome/browser/chromeos/boot_times_loader.cc b/chrome/browser/chromeos/boot_times_loader.cc index ca821444..f601332 100644 --- a/chrome/browser/chromeos/boot_times_loader.cc +++ b/chrome/browser/chromeos/boot_times_loader.cc @@ -212,7 +212,7 @@ static void SendBootTimesToUMA(const BootTimesLoader::BootTimes& boot_times) { } void BootTimesLoader::Backend::GetBootTimes( - scoped_refptr<GetBootTimesRequest> request) { + const scoped_refptr<GetBootTimesRequest>& request) { const FilePath::CharType kFirmwareBootTime[] = FPL("firmware-boot-time"); const FilePath::CharType kPreStartup[] = FPL("pre-startup"); const FilePath::CharType kChromeExec[] = FPL("chrome-exec"); @@ -356,13 +356,7 @@ void BootTimesLoader::LoginDone() { // Don't swamp the FILE thread right away. BrowserThread::PostDelayedTask( BrowserThread::FILE, FROM_HERE, - // This doesn't compile without std::string(...), as base::Bind doesn't - // accept arrays. - // TODO(jhawkins): Verify this is true for base::Bind. - base::Bind(WriteTimes, - std::string(kLoginTimes), - std::string(kUmaLogin), - std::string(kUmaLoginPrefix), + base::Bind(&WriteTimes, kLoginTimes, kUmaLogin, kUmaLoginPrefix, login_time_markers_), kLoginTimeWriteDelayMs); } @@ -377,7 +371,7 @@ void BootTimesLoader::WriteLogoutTimes() { void BootTimesLoader::RecordStats(const std::string& name, const Stats& stats) { BrowserThread::PostTask( BrowserThread::FILE, FROM_HERE, - base::Bind(RecordStatsDelayed, name, stats.uptime, stats.disk)); + base::Bind(&RecordStatsDelayed, name, stats.uptime, stats.disk)); } BootTimesLoader::Stats BootTimesLoader::GetCurrentStats() { |