diff options
author | satorux@chromium.org <satorux@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2013-04-17 03:55:29 +0000 |
---|---|---|
committer | satorux@chromium.org <satorux@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2013-04-17 03:55:29 +0000 |
commit | adbe1348fc14fc502ca0dc7de3002d37398a07b9 (patch) | |
tree | ffedb28a4541dfe8160144d84763d00398c04f08 /chrome/browser/chromeos/extensions/file_manager/drive_test_util.cc | |
parent | 71a84decce960f2ffa4feed50c3125c8de3f7588 (diff) | |
download | chromium_src-adbe1348fc14fc502ca0dc7de3002d37398a07b9.zip chromium_src-adbe1348fc14fc502ca0dc7de3002d37398a07b9.tar.gz chromium_src-adbe1348fc14fc502ca0dc7de3002d37398a07b9.tar.bz2 |
Revert 194525 "Add InitWidgets() phase for GTK infobars."
Broke "Linux Tests (dbg)(2)" build.
http://build.chromium.org/p/chromium.linux/builders/Linux%20Tests%20%28dbg%29%282%29/builds/33655
[4808:4808:0416/202705:277959527:FATAL:browser_main_loop.cc(186)] Gtk: gtk_box_pack: assertion `GTK_IS_WIDGET (child)' failed
The error is FATAL with a Debug build but ERROR with a Release build, hence linux_rel try bot passed:
http://build.chromium.org/p/tryserver.chromium/builders/linux_rel/builds/117475/steps/interactive_ui_tests/logs/stdio
[10001:10001:0416/181034:1303866619:ERROR:browser_main_loop.cc(186)] Gtk: gtk_box_pack: assertion `GTK_IS_WIDGET (child)' failed
> Add InitWidgets() phase for GTK infobars.
>
> This unifies the creation of GTK widgets and makes it happen in response to the infobar being shown. Currently, this generally happens at construction. Once the new ownership model lands, infobars will not yet be owned at construction time, and since widget creation includes getting a theme service from the owner, that needs to move out of the construction phase.
>
> Incidentally, this also makes the GTK native object creation happen at the same time as the views native object creation, not that that matters much.
>
> BUG=none
> TEST=none
>
> Review URL: https://codereview.chromium.org/11775019
TBR=pkasting@chromium.org
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@194528 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/browser/chromeos/extensions/file_manager/drive_test_util.cc')
0 files changed, 0 insertions, 0 deletions