diff options
| author | erikchen@chromium.org <erikchen@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2014-03-05 10:18:21 +0000 |
|---|---|---|
| committer | erikchen@chromium.org <erikchen@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2014-03-05 10:18:21 +0000 |
| commit | 7c7a224a4378a350449e3ce47496338ad5fde7f6 (patch) | |
| tree | f77ccfcb7cc47940f1817f32f46c37678b6c4509 /chrome/browser/chromeos/extensions/media_player_api.cc | |
| parent | db024825de7b10be6382b216c11cda7c8aa16af4 (diff) | |
| download | chromium_src-7c7a224a4378a350449e3ce47496338ad5fde7f6.zip chromium_src-7c7a224a4378a350449e3ce47496338ad5fde7f6.tar.gz chromium_src-7c7a224a4378a350449e3ce47496338ad5fde7f6.tar.bz2 | |
mac: History swipe arrow disappears slowly with magic mouse.
The history swipe arrow was being dismissed at the wrong time. It should be
dismissed as soon as the browser begins to navigate forwards or backwards. It
was being dismissed when the gesture completed, which takes ~1 second longer,
due to momentum swipe events that keep coming in after a user has let go.
This bug came from an incorrect revival of previously deleted code. This CL
fixes the newly introduced bug, but introduces a behavioral change. There are
3 possible end conditions for the history swipe:
1. PhaseEnded & navigation occurs
2. PhaseEnded & no navigation occurs
3. PhaseCancelled, no navigation occurs
There's no way for the user to differentiate 2&3, so the behavior between them
should be consistent. In the dead code, 1&2 had an animated dismissal of the
arrow, whereas 3 had an instant dismissal of the arrow. In this patch, I've
unified the logic to always use an animated dismissal of the arrow.
BUG=338206
Review URL: https://codereview.chromium.org/184813007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@254997 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/browser/chromeos/extensions/media_player_api.cc')
0 files changed, 0 insertions, 0 deletions