diff options
| author | nona@chromium.org <nona@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2013-04-18 15:20:16 +0000 |
|---|---|---|
| committer | nona@chromium.org <nona@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2013-04-18 15:20:16 +0000 |
| commit | 20fd79eeb79b9a0f8770a708ddcbf7f66564b57f (patch) | |
| tree | 6748353019aa0dd758b5bfc820b6c1a3279f706d /chrome/browser/chromeos/input_method/input_method_delegate_impl.h | |
| parent | 002aec6aa74169469c214ec1a2b66f91678bf823 (diff) | |
| download | chromium_src-20fd79eeb79b9a0f8770a708ddcbf7f66564b57f.zip chromium_src-20fd79eeb79b9a0f8770a708ddcbf7f66564b57f.tar.gz chromium_src-20fd79eeb79b9a0f8770a708ddcbf7f66564b57f.tar.bz2 | |
Decouple l10n_util from InputMethodUtil.
This CL changes:
- Moving localization related function into delegate class.
- Removing GetLanguageDisplayNameFromCode and GetLanguageNativeDisplayNameFromCode from InputMethodUtil because they are just thin wrapper function of l10n_util and only used from CrosLanguageOptionHandler.
This CL does not change any test expectations except TestGetLanguageNativeDisplayNameFromCode for checking regressions.
And I'm going to refactor strings related stuff to more appropriate location.
So let me keep tests as is.
BUG=164375
TEST=ran unit_tests and also checked there is no regression with this CL on actual devices.
Review URL: https://chromiumcodereview.appspot.com/14200032
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@194927 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/browser/chromeos/input_method/input_method_delegate_impl.h')
| -rw-r--r-- | chrome/browser/chromeos/input_method/input_method_delegate_impl.h | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/chrome/browser/chromeos/input_method/input_method_delegate_impl.h b/chrome/browser/chromeos/input_method/input_method_delegate_impl.h index 541aa71..cb15566 100644 --- a/chrome/browser/chromeos/input_method/input_method_delegate_impl.h +++ b/chrome/browser/chromeos/input_method/input_method_delegate_impl.h @@ -22,7 +22,9 @@ class InputMethodDelegateImpl : public InputMethodDelegate { // InputMethodDelegate implementation. virtual std::string GetHardwareKeyboardLayout() const OVERRIDE; - virtual std::string GetActiveLocale() const OVERRIDE; + virtual string16 GetLocalizedString(int resource_id) const OVERRIDE; + virtual string16 GetDisplayLanguageName( + const std::string& language_code) const OVERRIDE; private: DISALLOW_COPY_AND_ASSIGN(InputMethodDelegateImpl); |