diff options
| author | nona@chromium.org <nona@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2013-04-26 09:49:42 +0000 |
|---|---|---|
| committer | nona@chromium.org <nona@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2013-04-26 09:49:42 +0000 |
| commit | f33618b05ccd75ae370044cea0f581c2c783364b (patch) | |
| tree | 89cb9e8734c26f84686883109a56002033ffccc6 /chrome/browser/chromeos/input_method/input_method_manager_impl.h | |
| parent | de6621cdcc17df3d5bd06df092b17761881352da (diff) | |
| download | chromium_src-f33618b05ccd75ae370044cea0f581c2c783364b.zip chromium_src-f33618b05ccd75ae370044cea0f581c2c783364b.tar.gz chromium_src-f33618b05ccd75ae370044cea0f581c2c783364b.tar.bz2 | |
Fix memory leak around InputMethodManagerImpl::Init
We may be able to fix this leak by introducing base::ConstRef, but component_extension_manager_impl already has the dependency to BrowserThread.
So I changed Init function to post task to FILE thread directly because this does not have any additional dependency.
Let me split CL from removing suppression because I couldn't check this actually fix the target leak because bot seems not working.
And I also couldn't reproduced on my local machine even I removed suppression.
BUG=225596
TEST=check this does not break anything but we couldn't check valgrind due to bot issue.
Review URL: https://chromiumcodereview.appspot.com/13835015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@196690 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/browser/chromeos/input_method/input_method_manager_impl.h')
| -rw-r--r-- | chrome/browser/chromeos/input_method/input_method_manager_impl.h | 6 |
1 files changed, 2 insertions, 4 deletions
diff --git a/chrome/browser/chromeos/input_method/input_method_manager_impl.h b/chrome/browser/chromeos/input_method/input_method_manager_impl.h index 38f4520..af7d19f 100644 --- a/chrome/browser/chromeos/input_method/input_method_manager_impl.h +++ b/chrome/browser/chromeos/input_method/input_method_manager_impl.h @@ -42,8 +42,7 @@ class InputMethodManagerImpl : public InputMethodManager, // to the InputMethodManagerImpl object. You don't have to call this function // if you attach them yourself (e.g. in unit tests) using the protected // setters. - void Init(const scoped_refptr<base::SequencedTaskRunner>& ui_task_runner, - const scoped_refptr<base::SequencedTaskRunner>& file_task_runner); + void Init(base::SequencedTaskRunner* ui_task_runner); // Receives notification of an InputMethodManager::State transition. void SetState(State new_state); @@ -149,8 +148,7 @@ class InputMethodManagerImpl : public InputMethodManager, // Called when the ComponentExtensionIMEManagerDelegate is initialized. void OnComponentExtensionInitialized( scoped_ptr<ComponentExtensionIMEManagerDelegate> delegate); - void InitializeComponentExtension( - const scoped_refptr<base::SequencedTaskRunner>& file_task_runner); + void InitializeComponentExtension(); // Loads necessary component extensions. // TODO(nona): Support dynamical unloading. |