Decompose BrowserStateMonitor into two parts, simplifying unit tests and APIs.

Decouple InputMethodManagerImpl from content notifications by requiring the client to push said notifications. BrowserStateMonitor and InputMethodPersistence thus become part of the client (configuration layer).

BUG=164375
TBR=sky

Review URL: https://chromiumcodereview.appspot.com/11466010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@173015 0039d316-1c4b-4281-b951-d872f2087c98

1 files changed, 111 insertions, 0 deletions

diff --git a/chrome/browser/chromeos/input_method/input_method_persistence_unittest.cc b/chrome/browser/chromeos/input_method/input_method_persistence_unittest.cc
new file mode 100644
index 0000000..2581070
--- /dev/null
+++ b/chrome/browser/chromeos/input_method/input_method_persistence_unittest.cc
@@ -0,0 +1,111 @@
+// Copyright (c) 2012 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "chrome/browser/chromeos/input_method/input_method_persistence.h"
+
+#include "base/command_line.h"
+#include "chrome/browser/chromeos/input_method/mock_input_method_manager.h"
+#include "chrome/browser/chromeos/language_preferences.h"
+#include "chrome/browser/prefs/pref_service.h"
+#include "chrome/browser/profiles/profile_manager.h"
+#include "chrome/common/chrome_switches.h"
+#include "chrome/common/pref_names.h"
+#include "chrome/test/base/testing_browser_process.h"
+#include "chrome/test/base/testing_pref_service.h"
+#include "chrome/test/base/testing_profile.h"
+#include "chrome/test/base/testing_profile_manager.h"
+
+#include "testing/gtest/include/gtest/gtest.h"
+
+namespace chromeos {
+namespace input_method {
+
+namespace {
+const char kInputId1[] = "xkb:us:dvorak:eng";
+const char kInputId2[] = "xkb:us:colemak:eng";
+const char kProfileName[] = "input_method_test";
+}
+
+class InputMethodPersistenceTest : public testing::Test {
+ protected:
+  InputMethodPersistenceTest()
+      : mock_profile_manager_(
+          static_cast<TestingBrowserProcess*>(g_browser_process)) {
+  }
+
+  virtual void SetUp() OVERRIDE {
+    // Set up a profile that will be returned by
+    // ProfileManager::GetDefaultProfile().
+    ASSERT_TRUE(mock_profile_manager_.SetUp());
+    TestingProfile* mock_profile =
+        mock_profile_manager_.CreateTestingProfile(kProfileName);
+    CommandLine *cl = CommandLine::ForCurrentProcess();
+    cl->AppendSwitchASCII(switches::kLoginProfile, kProfileName);
+    mock_profile_manager_.SetLoggedIn(true);
+    EXPECT_TRUE(ProfileManager::GetDefaultProfile() != NULL);
+    mock_user_prefs_ = mock_profile->GetTestingPrefService();
+  }
+
+  // Verifies that the user and system prefs contain the expected values.
+  void VerifyPrefs(const std::string& current_input_method,
+                   const std::string& previous_input_method,
+                   const std::string& preferred_keyboard_layout) {
+    EXPECT_EQ(current_input_method,
+              mock_user_prefs_->GetString(prefs::kLanguageCurrentInputMethod));
+    EXPECT_EQ(previous_input_method,
+              mock_user_prefs_->GetString(prefs::kLanguagePreviousInputMethod));
+    EXPECT_EQ(preferred_keyboard_layout,
+              g_browser_process->local_state()->GetString(
+                  language_prefs::kPreferredKeyboardLayout));
+  }
+
+  TestingPrefService* mock_user_prefs_;
+  MockInputMethodManager mock_manager_;
+  TestingProfileManager mock_profile_manager_;
+};
+
+TEST_F(InputMethodPersistenceTest, TestLifetime) {
+  {
+    InputMethodPersistence persistence(&mock_manager_);
+    EXPECT_EQ(1, mock_manager_.add_observer_count_);
+  }
+  EXPECT_EQ(1, mock_manager_.remove_observer_count_);
+}
+
+TEST_F(InputMethodPersistenceTest, TestPrefPersistenceByState) {
+  InputMethodPersistence persistence(&mock_manager_);
+
+  persistence.OnSessionStateChange(InputMethodManager::STATE_LOGIN_SCREEN);
+  mock_manager_.SetCurrentInputMethodId(kInputId1);
+  persistence.InputMethodChanged(&mock_manager_, false);
+  VerifyPrefs("", "", kInputId1);
+
+  persistence.OnSessionStateChange(InputMethodManager::STATE_BROWSER_SCREEN);
+  mock_manager_.SetCurrentInputMethodId(kInputId2);
+  persistence.InputMethodChanged(&mock_manager_, false);
+  VerifyPrefs(kInputId2, "", kInputId1);
+
+  persistence.OnSessionStateChange(InputMethodManager::STATE_LOCK_SCREEN);
+  mock_manager_.SetCurrentInputMethodId(kInputId1);
+  persistence.InputMethodChanged(&mock_manager_, false);
+  VerifyPrefs(kInputId2, "", kInputId1);
+
+  persistence.OnSessionStateChange(InputMethodManager::STATE_TERMINATING);
+  mock_manager_.SetCurrentInputMethodId(kInputId1);
+  persistence.InputMethodChanged(&mock_manager_, false);
+  VerifyPrefs(kInputId2, "", kInputId1);
+
+  persistence.OnSessionStateChange(InputMethodManager::STATE_LOGIN_SCREEN);
+  mock_manager_.SetCurrentInputMethodId(kInputId2);
+  persistence.InputMethodChanged(&mock_manager_, false);
+  VerifyPrefs(kInputId2, "", kInputId2);
+
+  persistence.OnSessionStateChange(InputMethodManager::STATE_BROWSER_SCREEN);
+  mock_manager_.SetCurrentInputMethodId(kInputId1);
+  persistence.InputMethodChanged(&mock_manager_, false);
+  VerifyPrefs(kInputId1, kInputId2, kInputId2);
+}
+
+}  // namespace input_method
+}  // namespace chromeos