summaryrefslogtreecommitdiffstats
path: root/chrome/browser/chromeos/input_method
diff options
context:
space:
mode:
authorzork@chromium.org <zork@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2014-03-28 21:12:07 +0000
committerzork@chromium.org <zork@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2014-03-28 21:12:07 +0000
commit1488a035f4377aa3cc443a4846e5058fc2a6acb4 (patch)
tree0043356ac199af9d7b7e91869bdbf0c0707c5233 /chrome/browser/chromeos/input_method
parent01bdc9206f8de9eac03ca7da9a736652f1d6add1 (diff)
downloadchromium_src-1488a035f4377aa3cc443a4846e5058fc2a6acb4.zip
chromium_src-1488a035f4377aa3cc443a4846e5058fc2a6acb4.tar.gz
chromium_src-1488a035f4377aa3cc443a4846e5058fc2a6acb4.tar.bz2
Update StickyKeys overlay to show or hide AltGr depending on the
current input method. BUG=335368 Review URL: https://codereview.chromium.org/187313002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260280 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/browser/chromeos/input_method')
-rw-r--r--chrome/browser/chromeos/input_method/input_method_manager_impl.cc8
-rw-r--r--chrome/browser/chromeos/input_method/input_method_manager_impl.h2
-rw-r--r--chrome/browser/chromeos/input_method/mock_input_method_manager.cc11
-rw-r--r--chrome/browser/chromeos/input_method/mock_input_method_manager.h6
4 files changed, 26 insertions, 1 deletions
diff --git a/chrome/browser/chromeos/input_method/input_method_manager_impl.cc b/chrome/browser/chromeos/input_method/input_method_manager_impl.cc
index 4a8912e..45588b6 100644
--- a/chrome/browser/chromeos/input_method/input_method_manager_impl.cc
+++ b/chrome/browser/chromeos/input_method/input_method_manager_impl.cc
@@ -715,6 +715,14 @@ InputMethodDescriptor InputMethodManagerImpl::GetCurrentInputMethod() const {
return current_input_method_;
}
+bool InputMethodManagerImpl::IsISOLevel5ShiftUsedByCurrentInputMethod() const {
+ return xkeyboard_->IsISOLevel5ShiftAvailable();
+}
+
+bool InputMethodManagerImpl::IsAltGrUsedByCurrentInputMethod() const {
+ return xkeyboard_->IsAltGrAvailable();
+}
+
XKeyboard* InputMethodManagerImpl::GetXKeyboard() {
return xkeyboard_.get();
}
diff --git a/chrome/browser/chromeos/input_method/input_method_manager_impl.h b/chrome/browser/chromeos/input_method/input_method_manager_impl.h
index 7d6447e..23ec79c 100644
--- a/chrome/browser/chromeos/input_method/input_method_manager_impl.h
+++ b/chrome/browser/chromeos/input_method/input_method_manager_impl.h
@@ -81,6 +81,8 @@ class InputMethodManagerImpl : public InputMethodManager,
const ui::Accelerator& accelerator) OVERRIDE;
virtual bool SwitchInputMethod(const ui::Accelerator& accelerator) OVERRIDE;
virtual InputMethodDescriptor GetCurrentInputMethod() const OVERRIDE;
+ virtual bool IsISOLevel5ShiftUsedByCurrentInputMethod() const OVERRIDE;
+ virtual bool IsAltGrUsedByCurrentInputMethod() const OVERRIDE;
virtual XKeyboard* GetXKeyboard() OVERRIDE;
virtual InputMethodUtil* GetInputMethodUtil() OVERRIDE;
diff --git a/chrome/browser/chromeos/input_method/mock_input_method_manager.cc b/chrome/browser/chromeos/input_method/mock_input_method_manager.cc
index 95142a3..6045c7a 100644
--- a/chrome/browser/chromeos/input_method/mock_input_method_manager.cc
+++ b/chrome/browser/chromeos/input_method/mock_input_method_manager.cc
@@ -10,7 +10,8 @@ namespace input_method {
MockInputMethodManager::MockInputMethodManager()
: add_observer_count_(0),
remove_observer_count_(0),
- util_(&delegate_, whitelist_.GetSupportedInputMethods()) {
+ util_(&delegate_, whitelist_.GetSupportedInputMethods()),
+ mod3_used_(false) {
active_input_method_ids_.push_back("xkb:us::eng");
}
@@ -144,6 +145,14 @@ InputMethodDescriptor MockInputMethodManager::GetCurrentInputMethod() const {
return descriptor;
}
+bool MockInputMethodManager::IsISOLevel5ShiftUsedByCurrentInputMethod() const {
+ return mod3_used_;
+}
+
+bool MockInputMethodManager::IsAltGrUsedByCurrentInputMethod() const {
+ return false;
+}
+
XKeyboard* MockInputMethodManager::GetXKeyboard() {
return &xkeyboard_;
}
diff --git a/chrome/browser/chromeos/input_method/mock_input_method_manager.h b/chrome/browser/chromeos/input_method/mock_input_method_manager.h
index 25f21c0..3f9c600 100644
--- a/chrome/browser/chromeos/input_method/mock_input_method_manager.h
+++ b/chrome/browser/chromeos/input_method/mock_input_method_manager.h
@@ -58,6 +58,8 @@ class MockInputMethodManager : public InputMethodManager {
const ui::Accelerator& accelerator) OVERRIDE;
virtual bool SwitchInputMethod(const ui::Accelerator& accelerator) OVERRIDE;
virtual InputMethodDescriptor GetCurrentInputMethod() const OVERRIDE;
+ virtual bool IsISOLevel5ShiftUsedByCurrentInputMethod() const OVERRIDE;
+ virtual bool IsAltGrUsedByCurrentInputMethod() const OVERRIDE;
virtual XKeyboard* GetXKeyboard() OVERRIDE;
virtual InputMethodUtil* GetInputMethodUtil() OVERRIDE;
virtual ComponentExtensionIMEManager*
@@ -74,6 +76,9 @@ class MockInputMethodManager : public InputMethodManager {
// Set values that will be provided to the InputMethodUtil.
void set_application_locale(const std::string& value);
+ // Set the value returned by IsISOLevel5ShiftUsedByCurrentInputMethod
+ void set_mod3_used(bool value) { mod3_used_ = value; }
+
// TODO(yusukes): Add more variables for counting the numbers of the API calls
int add_observer_count_;
int remove_observer_count_;
@@ -86,6 +91,7 @@ class MockInputMethodManager : public InputMethodManager {
FakeInputMethodDelegate delegate_; // used by util_
InputMethodUtil util_;
FakeXKeyboard xkeyboard_;
+ bool mod3_used_;
// The active input method ids cache (actually default only)
std::vector<std::string> active_input_method_ids_;