diff options
author | jamescook@chromium.org <jamescook@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2011-09-14 19:40:43 +0000 |
---|---|---|
committer | jamescook@chromium.org <jamescook@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2011-09-14 19:40:43 +0000 |
commit | d191b309dbfabe1af1f97242ceaa79a6320cb769 (patch) | |
tree | 762d5c4d6231b45ac371bb4c91eed3d3677fc20d /chrome/browser/chromeos/sim_dialog_delegate.cc | |
parent | 9ecbeb63cc03c3d95a09a2f76ea35da31f0ec4d7 (diff) | |
download | chromium_src-d191b309dbfabe1af1f97242ceaa79a6320cb769.zip chromium_src-d191b309dbfabe1af1f97242ceaa79a6320cb769.tar.gz chromium_src-d191b309dbfabe1af1f97242ceaa79a6320cb769.tar.bz2 |
CrOS: Use square borders for dialogs, allow content flush to edge
After talking to UX, we're moving in the direction of square dialogs on Chrome OS. This patch:
* Allows us to host web content in a dialog that goes flush to the
edges, (see bug for example) and
* Is consistent with WebUI "dialogs" that are square right now
I think this looks better for the cases I've looked at (file picker, task manager, mobile network chooser, sim card unlocker, keyboard shortcut overlay). It also allows us to get rid of STYLE_XSHAPE and the GTK-specific hacks to trim the window corners for the keyboard
shortcut overlay.
BUG=chromium-os:19715
TEST=Open file picker with control-O, verify dialog is square and the gradient fill in the header (behind "Select a file") extends up to the edge of the window. Go to web store and click the button to install an extension. Verify the installation confirm dialog still has padding between the text and the edge of the window.
Review URL: http://codereview.chromium.org/7889042
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@101128 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/browser/chromeos/sim_dialog_delegate.cc')
-rw-r--r-- | chrome/browser/chromeos/sim_dialog_delegate.cc | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/chrome/browser/chromeos/sim_dialog_delegate.cc b/chrome/browser/chromeos/sim_dialog_delegate.cc index 34f8c20..c05537f 100644 --- a/chrome/browser/chromeos/sim_dialog_delegate.cc +++ b/chrome/browser/chromeos/sim_dialog_delegate.cc @@ -54,9 +54,9 @@ void SimDialogDelegate::ShowDialog(gfx::NativeWindow owning_window, HtmlDialogView* html_view = new HtmlDialogView(profile, new SimDialogDelegate(mode)); html_view->InitDialog(); - chromeos::BubbleWindow::Create(owning_window, - chromeos::STYLE_GENERIC, - html_view); + BubbleWindow::Create(owning_window, + STYLE_FLUSH, + html_view); html_view->GetWidget()->Show(); } |