diff options
| author | jrg@chromium.org <jrg@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-07-20 22:53:21 +0000 |
|---|---|---|
| committer | jrg@chromium.org <jrg@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-07-20 22:53:21 +0000 |
| commit | 48f9382593d5c56d98b270fe2185299402e54509 (patch) | |
| tree | a6ebd9a26b288ebb1f1008709116f0fbf45d0bac /chrome/browser/cocoa/bookmark_bar_controller.h | |
| parent | 16f9251aa41c321f7cf04d18b319a80c90690573 (diff) | |
| download | chromium_src-48f9382593d5c56d98b270fe2185299402e54509.zip chromium_src-48f9382593d5c56d98b270fe2185299402e54509.tar.gz chromium_src-48f9382593d5c56d98b270fe2185299402e54509.tar.bz2 | |
Don't make all bookmark buttons the same width.
Make thinner if possible.
Feelin luv 4 pink.
BUG=http://crbug.com/16942
TEST=2 main parts:
1)
Create bookmarks (click 'Star').
Make sure long titles get trimmed.
Make sure small titles have smaller buttons and text does NOT get trimmed.
Quit and launch with bookmark bar open.
Make sure things are still fine (icons load after bar first assembled).
2)
Quit Chromium.
Rename a LONG button title by editing ~/Library/Application Support/Chromium/Default/Bookmarks.
Relaunch Chromium.
Make sure the button is now smaller but is not "trimmed" (e.g. all the text is there).
Repeat for 5 buttons with different short (5-10 char) titles on each.
Make sure the buttons are smaller and the text is NOT trimmed.
Review URL: http://codereview.chromium.org/155712
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21121 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/browser/cocoa/bookmark_bar_controller.h')
| -rw-r--r-- | chrome/browser/cocoa/bookmark_bar_controller.h | 7 |
1 files changed, 7 insertions, 0 deletions
diff --git a/chrome/browser/cocoa/bookmark_bar_controller.h b/chrome/browser/cocoa/bookmark_bar_controller.h index 1e98b93..662da61 100644 --- a/chrome/browser/cocoa/bookmark_bar_controller.h +++ b/chrome/browser/cocoa/bookmark_bar_controller.h @@ -40,6 +40,9 @@ class PrefService; BOOL contentViewHasOffset_; BOOL barShouldBeShown_; + // Our bookmark buttons, ordered from L-->R. + scoped_nsobject<NSMutableArray> buttons_; + // If the bar is disabled, we hide it and ignore show/hide commands. // Set when using fullscreen mode. BOOL barIsEnabled_; @@ -115,6 +118,10 @@ class PrefService; @interface BookmarkBarController(TestingAPI) // Set the delegate for a unit test. - (void)setDelegate:(id<BookmarkURLOpener>)delegate; +- (void)clearBookmarkBar; +- (NSArray*)buttons; +- (NSRect)frameForBookmarkButtonFromCell:(NSCell*)cell xOffset:(int*)xOffset; +- (void)checkForBookmarkButtonGrowth:(NSButton*)button; @end #endif // CHROME_BROWSER_COCOA_BOOKMARK_BAR_CONTROLLER_H_ |