diff options
| author | shess@chromium.org <shess@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-12-10 21:18:03 +0000 |
|---|---|---|
| committer | shess@chromium.org <shess@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-12-10 21:18:03 +0000 |
| commit | 9e43ee4061beb03ab170520b6b511025b8eaf236 (patch) | |
| tree | fde04088071f2d696f90928874470cf07055b3ab /chrome/browser/cocoa/keyword_editor_cocoa_controller.mm | |
| parent | e8c20ffc89d4194aa290206d95f6fdf19b4d12ea (diff) | |
| download | chromium_src-9e43ee4061beb03ab170520b6b511025b8eaf236.zip chromium_src-9e43ee4061beb03ab170520b6b511025b8eaf236.tar.gz chromium_src-9e43ee4061beb03ab170520b6b511025b8eaf236.tar.bz2 | |
[Mac] Attempt to fix ref-after-free problems with NSTableView dataSource.
Clearing dataSource in the source's -dealloc seems generally good.
HungRendererController having a local copy of the titles is in case
the table view is redrawn as part of closing the window (this can
happen if the window is closed while the user is mousing on the
table, and perhaps at other times).
BUG=29558
TEST=Crash noted in bug stops happening.
Review URL: http://codereview.chromium.org/469016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34281 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/browser/cocoa/keyword_editor_cocoa_controller.mm')
| -rw-r--r-- | chrome/browser/cocoa/keyword_editor_cocoa_controller.mm | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/chrome/browser/cocoa/keyword_editor_cocoa_controller.mm b/chrome/browser/cocoa/keyword_editor_cocoa_controller.mm index 37ffdf3..d2e1d7a 100644 --- a/chrome/browser/cocoa/keyword_editor_cocoa_controller.mm +++ b/chrome/browser/cocoa/keyword_editor_cocoa_controller.mm @@ -185,7 +185,7 @@ typedef std::map<Profile*,KeywordEditorCocoaController*> ProfileControllerMap; - (void)dealloc { controller_->table_model()->SetObserver(NULL); controller_->url_model()->RemoveObserver(observer_.get()); - [tableView_ setTarget:nil]; + [tableView_ setDataSource:nil]; observer_.reset(); [super dealloc]; } |