diff options
author | thakis@chromium.org <thakis@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-06-16 18:35:05 +0000 |
---|---|---|
committer | thakis@chromium.org <thakis@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-06-16 18:35:05 +0000 |
commit | c14d2d3b28a599cbd42342549f1c5ae17ebd13d9 (patch) | |
tree | dc722f9f5dc977ded133e4036881925ec0160284 /chrome/browser/cocoa | |
parent | 032bca269dc5a1476e10662619612553db9b9cf7 (diff) | |
download | chromium_src-c14d2d3b28a599cbd42342549f1c5ae17ebd13d9.zip chromium_src-c14d2d3b28a599cbd42342549f1c5ae17ebd13d9.tar.gz chromium_src-c14d2d3b28a599cbd42342549f1c5ae17ebd13d9.tar.bz2 |
Revert 49986 - crash
TBR=thakis@chromium.org
Review URL: http://codereview.chromium.org/2808011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49998 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/browser/cocoa')
-rw-r--r-- | chrome/browser/cocoa/bookmark_bar_folder_controller.mm | 29 |
1 files changed, 14 insertions, 15 deletions
diff --git a/chrome/browser/cocoa/bookmark_bar_folder_controller.mm b/chrome/browser/cocoa/bookmark_bar_folder_controller.mm index 956acaa..752ab4b 100644 --- a/chrome/browser/cocoa/bookmark_bar_folder_controller.mm +++ b/chrome/browser/cocoa/bookmark_bar_folder_controller.mm @@ -1025,21 +1025,6 @@ static BOOL ValueInRangeInclusive(CGFloat low, CGFloat value, CGFloat high) { return [self dragBookmark:sourceNode to:point copy:copy]; } -// clang hack to work around http://llvm.org/bugs/show_bug.cgi?id=7386 -// TODO(mrossetti,jrg): Identical to the same function in BookmarkBarController. -// http://crbug.com/35966 -- (std::vector<const BookmarkNode*>)retrieveBookmarkDragDataNodes { - std::vector<const BookmarkNode*> dragDataNodes; - BookmarkDragData dragData; - if(dragData.ReadFromDragClipboard()) { - BookmarkModel* bookmarkModel = [self bookmarkModel]; - Profile* profile = bookmarkModel->profile(); - std::vector<const BookmarkNode*> nodes(dragData.GetNodes(profile)); - dragDataNodes.assign(nodes.begin(), nodes.end()); - } - return dragDataNodes; -} - // TODO(mrossetti,jrg): Identical to the same function in BookmarkBarController. // http://crbug.com/35966 - (BOOL)dragBookmarkData:(id<NSDraggingInfo>)info { @@ -1057,6 +1042,20 @@ static BOOL ValueInRangeInclusive(CGFloat low, CGFloat value, CGFloat high) { return dragged; } +// TODO(mrossetti,jrg): Identical to the same function in BookmarkBarController. +// http://crbug.com/35966 +- (std::vector<const BookmarkNode*>)retrieveBookmarkDragDataNodes { + std::vector<const BookmarkNode*> dragDataNodes; + BookmarkDragData dragData; + if(dragData.ReadFromDragClipboard()) { + BookmarkModel* bookmarkModel = [self bookmarkModel]; + Profile* profile = bookmarkModel->profile(); + std::vector<const BookmarkNode*> nodes(dragData.GetNodes(profile)); + dragDataNodes.assign(nodes.begin(), nodes.end()); + } + return dragDataNodes; +} + // Return YES if we should show the drop indicator, else NO. // TODO(jrg): ARGH code dup! // http://crbug.com/35966 |