diff options
author | jam@chromium.org <jam@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-11-07 01:06:28 +0000 |
---|---|---|
committer | jam@chromium.org <jam@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-11-07 01:06:28 +0000 |
commit | e60b6496879d9ab8a58abf998bfbd02aab834aba (patch) | |
tree | cd4068f309018fa553c5e1e282c48e1be02f02d7 /chrome/browser/debugger | |
parent | a45a84fa3d8005703a3cdbd204b25d40297599da (diff) | |
download | chromium_src-e60b6496879d9ab8a58abf998bfbd02aab834aba.zip chromium_src-e60b6496879d9ab8a58abf998bfbd02aab834aba.tar.gz chromium_src-e60b6496879d9ab8a58abf998bfbd02aab834aba.tar.bz2 |
Tenth patch in making destructors of refcounted objects private.
BUG=26749
Review URL: http://codereview.chromium.org/376007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31348 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/browser/debugger')
5 files changed, 10 insertions, 7 deletions
diff --git a/chrome/browser/debugger/debugger_remote_service.h b/chrome/browser/debugger/debugger_remote_service.h index b43ba48..7f6e4e8 100644 --- a/chrome/browser/debugger/debugger_remote_service.h +++ b/chrome/browser/debugger/debugger_remote_service.h @@ -40,7 +40,6 @@ class DebuggerRemoteService : public DevToolsRemoteListener { // V8 VM debugger are routed back to |delegate|. // The ownership of |delegate| is NOT transferred to this class. explicit DebuggerRemoteService(DevToolsProtocolHandler* delegate); - virtual ~DebuggerRemoteService(); // Handles a JSON message from the tab_uid-associated V8 debugger. void DebuggerOutput(int32 tab_uid, const std::string& message); @@ -84,6 +83,8 @@ class DebuggerRemoteService : public DevToolsRemoteListener { RESULT_UNKNOWN_COMMAND } Result; + virtual ~DebuggerRemoteService(); + // Attaches a remote debugger to the tab specified by |destination|. // Writes the attachment result (one of Result enum values) into |response|. void AttachToTab(const std::string& destination, diff --git a/chrome/browser/debugger/devtools_protocol_handler.h b/chrome/browser/debugger/devtools_protocol_handler.h index 41b2869..8c14a82 100644 --- a/chrome/browser/debugger/devtools_protocol_handler.h +++ b/chrome/browser/debugger/devtools_protocol_handler.h @@ -28,7 +28,6 @@ class DevToolsProtocolHandler ToolToListenerMap; explicit DevToolsProtocolHandler(int port); - virtual ~DevToolsProtocolHandler(); // This method should be called after the object construction. void Start(); @@ -66,6 +65,8 @@ class DevToolsProtocolHandler virtual void DidClose(ListenSocket *sock); private: + virtual ~DevToolsProtocolHandler(); + void Init(); void Teardown(); int port_; diff --git a/chrome/browser/debugger/devtools_remote_listen_socket_unittest.h b/chrome/browser/debugger/devtools_remote_listen_socket_unittest.h index 0ec0501..374df13 100644 --- a/chrome/browser/debugger/devtools_remote_listen_socket_unittest.h +++ b/chrome/browser/debugger/devtools_remote_listen_socket_unittest.h @@ -91,9 +91,6 @@ class DevToolsRemoteListenSocketTester : memset(&lock_, 0, sizeof(lock_)); } - virtual ~DevToolsRemoteListenSocketTester() { - } - virtual void SetUp(); virtual void TearDown(); @@ -138,6 +135,9 @@ class DevToolsRemoteListenSocketTester : protected: virtual ListenSocket* DoListen(); + + private: + virtual ~DevToolsRemoteListenSocketTester() {} }; #endif // CHROME_BROWSER_DEBUGGER_DEVTOOLS_REMOTE_LISTEN_SOCKET_UNITTEST_H_ diff --git a/chrome/browser/debugger/devtools_remote_service.h b/chrome/browser/debugger/devtools_remote_service.h index 5a4f3cd..68518ef 100644 --- a/chrome/browser/debugger/devtools_remote_service.h +++ b/chrome/browser/debugger/devtools_remote_service.h @@ -26,7 +26,6 @@ struct DevToolsRemoteServiceCommand { class DevToolsRemoteService : public DevToolsRemoteListener { public: explicit DevToolsRemoteService(DevToolsProtocolHandler* delegate); - virtual ~DevToolsRemoteService(); // DevToolsRemoteListener interface virtual void HandleMessage(const DevToolsRemoteMessage& message); @@ -40,6 +39,7 @@ class DevToolsRemoteService : public DevToolsRemoteListener { static const int kOk = 0; static const int kUnknownCommand = 1; }; + virtual ~DevToolsRemoteService(); void ProcessJson(DictionaryValue* json, const DevToolsRemoteMessage& message); static const std::wstring kCommandWide; static const std::wstring kDataWide; diff --git a/chrome/browser/debugger/extension_ports_remote_service.h b/chrome/browser/debugger/extension_ports_remote_service.h index 8d14e3d..005905c 100644 --- a/chrome/browser/debugger/extension_ports_remote_service.h +++ b/chrome/browser/debugger/extension_ports_remote_service.h @@ -34,7 +34,6 @@ class ExtensionPortsRemoteService : public DevToolsRemoteListener, // dispatches messages to this service. // The ownership of |delegate| is NOT transferred to this class. explicit ExtensionPortsRemoteService(DevToolsProtocolHandler* delegate); - virtual ~ExtensionPortsRemoteService(); // DevToolsRemoteListener methods: @@ -65,6 +64,8 @@ class ExtensionPortsRemoteService : public DevToolsRemoteListener, RESULT_CONNECT_FAILED, // probably extension ID not found. } Result; + virtual ~ExtensionPortsRemoteService(); + // Sends a JSON message with the |response| to the external client. // |tool| and |destination| are used as the respective header values. void SendResponse(const Value& response, |