Convert ReplaceStringPlaceholders(std::string...) to take a

StringPiece as the format string instead.  This allows us to save
a string copy in the new tab page.

Also clean up some code in the extensions process binding that
was doing excess string conversions.

BUG=26228

Review URL: http://codereview.chromium.org/347019

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30491 0039d316-1c4b-4281-b951-d872f2087c98

1 files changed, 2 insertions, 4 deletions

diff --git a/chrome/browser/dom_ui/dom_ui_theme_source.cc b/chrome/browser/dom_ui/dom_ui_theme_source.cc
index f81193d..49e227f 100644
--- a/chrome/browser/dom_ui/dom_ui_theme_source.cc
+++ b/chrome/browser/dom_ui/dom_ui_theme_source.cc
@@ -193,9 +193,8 @@ void DOMUIThemeSource::InitNewTabCSS() {
       IDR_NEW_TAB_THEME_CSS));
 
   // Create the string from our template and the replacements.
-  std::string format_string = new_tab_theme_css.as_string();
   const std::string css_string = ReplaceStringPlaceholders(
-      format_string, subst, NULL);
+      new_tab_theme_css, subst, NULL);
   new_tab_css_ = ReplaceStringPlaceholders(
       css_string, subst2, NULL);
 }
@@ -227,9 +226,8 @@ void DOMUIThemeSource::InitNewIncognitoTabCSS() {
       IDR_NEW_INCOGNITO_TAB_THEME_CSS));
 
   // Create the string from our template and the replacements.
-  std::string format_string = new_tab_theme_css.as_string();
   new_incognito_tab_css_ = ReplaceStringPlaceholders(
-      format_string, subst, NULL);
+      new_tab_theme_css, subst, NULL);
 }
 
 void DOMUIThemeSource::SendNewTabCSS(int request_id,