diff options
| author | brettw@chromium.org <brettw@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-04-04 17:55:46 +0000 |
|---|---|---|
| committer | brettw@chromium.org <brettw@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-04-04 17:55:46 +0000 |
| commit | 2b4355c4590724ae676f0ec5a8230e5c8c4cddf9 (patch) | |
| tree | a087c519b35898d4f8e097f223f7658fd9315638 /chrome/browser/dom_ui/dom_ui_unittest.cc | |
| parent | 1d5222071e5876b345e84d475573ef5db14ba1b4 (diff) | |
| download | chromium_src-2b4355c4590724ae676f0ec5a8230e5c8c4cddf9.zip chromium_src-2b4355c4590724ae676f0ec5a8230e5c8c4cddf9.tar.gz chromium_src-2b4355c4590724ae676f0ec5a8230e5c8c4cddf9.tar.bz2 | |
Make the throbber throb sooner after you navigate. This fixes the new tab page,
which would not start throbbing until the load committed. I think this was always
broken, but switching the tab contents types covered it up.
Now I have a flag that goes along with the tab updating that indicates if it's
a load update or a full update. This is necessary to avoid updating the title
to the page's URL until it does actually commit.
BUG=9310
Review URL: http://codereview.chromium.org/60066
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13131 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/browser/dom_ui/dom_ui_unittest.cc')
| -rw-r--r-- | chrome/browser/dom_ui/dom_ui_unittest.cc | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/chrome/browser/dom_ui/dom_ui_unittest.cc b/chrome/browser/dom_ui/dom_ui_unittest.cc index 63eb2e7..3371acf 100644 --- a/chrome/browser/dom_ui/dom_ui_unittest.cc +++ b/chrome/browser/dom_ui/dom_ui_unittest.cc @@ -137,7 +137,7 @@ TEST_F(DOMUITest, StandardToDOMUI) { GURL new_tab_url(chrome::kChromeUINewTabURL); controller()->LoadURL(new_tab_url, GURL(), PageTransition::LINK); EXPECT_FALSE(contents()->ShouldDisplayURL()); - EXPECT_FALSE(contents()->ShouldDisplayFavIcon()); + EXPECT_TRUE(contents()->ShouldDisplayFavIcon()); EXPECT_FALSE(contents()->IsBookmarkBarAlwaysVisible()); EXPECT_TRUE(contents()->FocusLocationBarByDefault()); |