summaryrefslogtreecommitdiffstats
path: root/chrome/browser/download/chrome_download_manager_delegate.h
diff options
context:
space:
mode:
authoraa@chromium.org <aa@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2012-05-27 18:06:22 +0000
committeraa@chromium.org <aa@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2012-05-27 18:06:22 +0000
commit7fb4bbb28abdfa66893f863f85e74e35ae1f75d5 (patch)
treeeadd4ae4b766958d6980351cea4a242f7a4d8336 /chrome/browser/download/chrome_download_manager_delegate.h
parentbc4ade2129b3d7464b36bc480e607b92ff3eb9ec (diff)
downloadchromium_src-7fb4bbb28abdfa66893f863f85e74e35ae1f75d5.zip
chromium_src-7fb4bbb28abdfa66893f863f85e74e35ae1f75d5.tar.gz
chromium_src-7fb4bbb28abdfa66893f863f85e74e35ae1f75d5.tar.bz2
Improve the UI for disabling off-store extension install.
Move the check later into install so that: 1) The download bar goes away. 2) There's an error message. 3) The same thing happens when double-clicking a crx, on systems that associate crx with Chrome. Also, made themes exempt from this policy since there is no danger in installing a theme. This left themes with a dangerous download bar that said 'Installing extensions, themes, and apps can harm your computer', which isn't even true for themes. It was only there to protect against clickjacking. Removed that and replaced with standard install dialog. Had to update a bunch of strings. BUG=55584 TEST=Run chrome with --enable-off-store-extension-install=0, navigate to a crx file. Should see error dialog. TBR=sky Review URL: https://chromiumcodereview.appspot.com/10452009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@139217 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/browser/download/chrome_download_manager_delegate.h')
-rw-r--r--chrome/browser/download/chrome_download_manager_delegate.h3
1 files changed, 0 insertions, 3 deletions
diff --git a/chrome/browser/download/chrome_download_manager_delegate.h b/chrome/browser/download/chrome_download_manager_delegate.h
index 8ec3d34f..bb6b160 100644
--- a/chrome/browser/download/chrome_download_manager_delegate.h
+++ b/chrome/browser/download/chrome_download_manager_delegate.h
@@ -48,9 +48,6 @@ class ChromeDownloadManagerDelegate
void SetDownloadManager(content::DownloadManager* dm);
- // Returns true if the given item is for an extension download.
- static bool IsExtensionDownload(const content::DownloadItem* item);
-
// Should be called before the first call to ShouldCompleteDownload() to
// disable SafeBrowsing checks for |item|.
static void DisableSafeBrowsing(content::DownloadItem* item);