diff options
| author | phajdan.jr@chromium.org <phajdan.jr@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-09-01 17:30:18 +0000 |
|---|---|---|
| committer | phajdan.jr@chromium.org <phajdan.jr@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-09-01 17:30:18 +0000 |
| commit | 47dbcd4e357f14f23ff42ffdd17a1711ee3d97f7 (patch) | |
| tree | 4d13f330b293ea6a9a3e2659cb5547d97331c3b9 /chrome/browser/download/download_manager_unittest.cc | |
| parent | c8c34a1ec4df1022d6a23ce190f2504f7da3a159 (diff) | |
| download | chromium_src-47dbcd4e357f14f23ff42ffdd17a1711ee3d97f7.zip chromium_src-47dbcd4e357f14f23ff42ffdd17a1711ee3d97f7.tar.gz chromium_src-47dbcd4e357f14f23ff42ffdd17a1711ee3d97f7.tar.bz2 | |
GTTF: Clean up DownloadFileManager
This removes a lot of duplication, locking, and thread jumping.
Most of the operations run on the FILE thread, and we do not duplicate
so much information. Each DownloadFile keeps track of its DownloadManager
(each Profile has its own DownloadManager). This allows us to remove
many maps from DownloadFileManager that were duplicating that information.
There is still SaveFileManager, but hopefully I will be able
to merge those two in small steps.
TEST=unit_tests, browser_tests, ui_tests
BUG=48913
Review URL: http://codereview.chromium.org/3245005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58196 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/browser/download/download_manager_unittest.cc')
| -rw-r--r-- | chrome/browser/download/download_manager_unittest.cc | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/chrome/browser/download/download_manager_unittest.cc b/chrome/browser/download/download_manager_unittest.cc index d63edc0..428ae8d 100644 --- a/chrome/browser/download/download_manager_unittest.cc +++ b/chrome/browser/download/download_manager_unittest.cc @@ -179,7 +179,7 @@ const struct { class MockDownloadFile : public DownloadFile { public: explicit MockDownloadFile(DownloadCreateInfo* info) - : DownloadFile(info), renamed_count_(0) { } + : DownloadFile(info, NULL), renamed_count_(0) { } virtual ~MockDownloadFile() { Destructed(); } MOCK_METHOD2(Rename, bool(const FilePath&, bool)); MOCK_METHOD0(DeleteCrDownload, void()); |