summaryrefslogtreecommitdiffstats
path: root/chrome/browser/download/download_util.h
diff options
context:
space:
mode:
authorrdsmith@chromium.org <rdsmith@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2012-02-17 20:11:11 +0000
committerrdsmith@chromium.org <rdsmith@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2012-02-17 20:11:11 +0000
commitc2d1a7f1d4e06928da3b9d7ef57cd72b3272cf99 (patch)
treede341edf5729bc17fed565818652c922777623ac /chrome/browser/download/download_util.h
parente73bd78073df416f9bc1f9633ef6b55fc1362d5e (diff)
downloadchromium_src-c2d1a7f1d4e06928da3b9d7ef57cd72b3272cf99.zip
chromium_src-c2d1a7f1d4e06928da3b9d7ef57cd72b3272cf99.tar.gz
chromium_src-c2d1a7f1d4e06928da3b9d7ef57cd72b3272cf99.tar.bz2
Added stale values that used to be used for the Download.CountsChrome
histogram. These are needed due to an incorrect refactor in http://codereview.chromium.org/9316116. BUG=None Review URL: http://codereview.chromium.org/9419015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@122562 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/browser/download/download_util.h')
-rw-r--r--chrome/browser/download/download_util.h24
1 files changed, 10 insertions, 14 deletions
diff --git a/chrome/browser/download/download_util.h b/chrome/browser/download/download_util.h
index 6a7a153..8bd4f21 100644
--- a/chrome/browser/download/download_util.h
+++ b/chrome/browser/download/download_util.h
@@ -174,22 +174,18 @@ void RecordShelfClose(int size, int in_progress, bool autoclose);
// Used for counting UMA stats. Similar to content's
// download_stats::DownloadCountTypes but from the chrome layer.
enum ChromeDownloadCountTypes {
+ // Stale enum values left around os that values passed to UMA don't
+ // change.
+ CHROME_DOWNLOAD_COUNT_UNUSED_0 = 0,
+ CHROME_DOWNLOAD_COUNT_UNUSED_1,
+ CHROME_DOWNLOAD_COUNT_UNUSED_2,
+ CHROME_DOWNLOAD_COUNT_UNUSED_3,
+
// A download *would* have been initiated, but it was blocked
// by the DownloadThrottlingResourceHandler.
- BLOCKED_BY_THROTTLING = 0,
-
- // The "= 2" is to get around a feature of the histogram system
- // which puts a floor of 1 for the minimum value for enum histograms
- // to allow there to be a bucket for values outside the expected range.
- // This isn't ideal since many (possibly most) enum histograms start
- // at zero, but there isn't any practical negative effect in UMA;
- // the zero value just uses the underflow bucket. However, if
- // a histogram only has one entry, it does result in a DCHECK because
- // the maximum value of the histogram is greater than the minimum value.
- // We solve this by bumping up the maximum value. This assignment
- // can be removed if any entries are added to this enum in the
- // future.
- CHROME_DOWNLOAD_COUNT_TYPES_LAST_ENTRY = 2
+ BLOCKED_BY_THROTTLING,
+
+ CHROME_DOWNLOAD_COUNT_TYPES_LAST_ENTRY
};
// Used for counting UMA stats. Similar to content's