diff options
| author | willchan@chromium.org <willchan@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-10-08 00:41:30 +0000 |
|---|---|---|
| committer | willchan@chromium.org <willchan@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-10-08 00:41:30 +0000 |
| commit | 1e2917814446b821d4c326282d819ddd318ff175 (patch) | |
| tree | 636cb3f1f97addf90ca31f90e9b5385fd9e3cba6 /chrome/browser/download/save_package.cc | |
| parent | f9e3c52fb5feba4c279dbbbec049aff0b45b3955 (diff) | |
| download | chromium_src-1e2917814446b821d4c326282d819ddd318ff175.zip chromium_src-1e2917814446b821d4c326282d819ddd318ff175.tar.gz chromium_src-1e2917814446b821d4c326282d819ddd318ff175.tar.bz2 | |
Fix instances of passing raw pointers to RefCounted objects in tasks.
Some of these manually handled it correctly by using AddRef()/Release() pairs. I switched them to make_scoped_refptr() to be more consistent. This also makes them cleanup properly on MessageLoop shutdown if we start deleting tasks.
BUG=28083
TEST=builds
Review URL: http://codereview.chromium.org/3581008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61899 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/browser/download/save_package.cc')
| -rw-r--r-- | chrome/browser/download/save_package.cc | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/chrome/browser/download/save_package.cc b/chrome/browser/download/save_package.cc index 4ce3e36..071e95b 100644 --- a/chrome/browser/download/save_package.cc +++ b/chrome/browser/download/save_package.cc @@ -1025,8 +1025,7 @@ void SavePackage::OnReceivedSerializedHtmlData(const GURL& frame_url, if (!data.empty()) { // Prepare buffer for saving HTML data. - net::IOBuffer* new_data = new net::IOBuffer(data.size()); - new_data->AddRef(); // We'll pass the buffer to SaveFileManager. + scoped_refptr<net::IOBuffer> new_data = new net::IOBuffer(data.size()); memcpy(new_data->data(), data.data(), data.size()); // Call write file functionality in file thread. |