diff options
| author | lukasza <lukasza@chromium.org> | 2015-12-30 15:48:32 -0800 |
|---|---|---|
| committer | Commit bot <commit-bot@chromium.org> | 2015-12-30 23:49:40 +0000 |
| commit | ede9cc06d2550f0ee0dce0285cc88c872809c1bb (patch) | |
| tree | 35a9d92ffebbf00ed515bc518843b0182771a30a /chrome/browser/download | |
| parent | e666e9a71d427a7c3efdc39b1aed8ea5cba844d4 (diff) | |
| download | chromium_src-ede9cc06d2550f0ee0dce0285cc88c872809c1bb.zip chromium_src-ede9cc06d2550f0ee0dce0285cc88c872809c1bb.tar.gz chromium_src-ede9cc06d2550f0ee0dce0285cc88c872809c1bb.tar.bz2 | |
OOPIFs: Deduplicating MHTML parts across frames.
Previous CL (crrev.com/1386873003) made MHTML serialization work in
presence of out-of-process iframes, but can potentially include the same
MHTML part twice. MHTML with duplicated parts can be rendered by Chrome
and Internet Explorer without problems (at least according to the
limited ad-hoc testing I've done), but the unnecessary increase of the
file size is a performance regression.
After the current CL, the browser keeps track of already serialized
MHTML parts and communicates them to the renderer/serializer for
each frame (so they can be deduped). This fixes the issue pointed
out above.
BUG=538766
Review URL: https://codereview.chromium.org/1417323006
Cr-Commit-Position: refs/heads/master@{#367206}
Diffstat (limited to 'chrome/browser/download')
| -rw-r--r-- | chrome/browser/download/save_page_browsertest.cc | 5 |
1 files changed, 1 insertions, 4 deletions
diff --git a/chrome/browser/download/save_page_browsertest.cc b/chrome/browser/download/save_page_browsertest.cc index a7e0a54..fbbe0e3 100644 --- a/chrome/browser/download/save_page_browsertest.cc +++ b/chrome/browser/download/save_page_browsertest.cc @@ -908,10 +908,7 @@ IN_PROC_BROWSER_TEST_F(SavePageSitePerProcessBrowserTest, SaveAsMHTML) { count++; pos++; } - // TODO(lukasza): Need to dedupe savable resources (i.e. 1.png) across frames. - // This will be fixed by crrev.com/1417323006. - // EXPECT_EQ(1, count) - // << "Verify number of image/png parts in the mhtml output"; + EXPECT_EQ(1, count) << "Verify number of image/png parts in the mhtml output"; } // Test suite that verifies that the frame tree "looks" the same before |