diff options
author | lukasza <lukasza@chromium.org> | 2015-07-20 13:57:20 -0700 |
---|---|---|
committer | Commit bot <commit-bot@chromium.org> | 2015-07-20 20:58:23 +0000 |
commit | 8acc4eb18b6919f36413a10718a607f2a34fb8f6 (patch) | |
tree | 1e53fa500119384a12b38075ebcc97a469750dd7 /chrome/browser/drive/dummy_drive_service.h | |
parent | 1f37aaf390288b2864efe98a07427dbf91771489 (diff) | |
download | chromium_src-8acc4eb18b6919f36413a10718a607f2a34fb8f6.zip chromium_src-8acc4eb18b6919f36413a10718a607f2a34fb8f6.tar.gz chromium_src-8acc4eb18b6919f36413a10718a607f2a34fb8f6.tar.bz2 |
Move (most of) chrome/browser/drive into components/drive.
Note that drive_notification_manager_factory is left behind in
chrome/browser/drive. This is because it needs to stay dependent on the
browser. This is okay, because drive_notification_manager_factory is
not needed by drive::FileSystem and other parts of drive libraries that
we want to componentize.
Also note that some things moved to components/drive continue to
have slightly undesirable dependencies:
- Tests are still built and executed as part of the browser test suites.
- drive_uploader.cc depends on content/public/browser/power_save_blocker.h
This means that to use components/drive outside of the browser,
users of components/drive have to provide a no-op implementation
of power_save_blocker.h
The most desirable approach in the long-term would be to componentize
power_save_blocker.h. An alternative would be to continue with
the state introduced by the current changelist (or to introduce
drive-specific abstraction similar to power_save_blocker.h, but
outside of the browser).
- drive_api_util.cc depends on storage/browser/fileapi/file_stream_reader.h
To get rid of this dependency, it is probably best to move
FileStreamMd5Digester class closer to the only point of usage
(c/b/chromeos/extensions/file_manager/private_api_file_system.cc).
Landing via CQ with NOPRESUBMIT=true, because "git cl presubmit" incorrectly
identifies target directory of a dependency (we are depending on
third_party/cacheinvalidation/src/google/cacheinvalidation/types.proto
and including the generated header via google/cacheinvalidation/types.pb.h).
I believe this is a case of crbug.com/448570. All other presubmit checks
are passing AFAIK:
$ git cl presubmit
Running presubmit commit checks ...
** Presubmit ERRORS **
Missing LGTM from OWNERS of dependencies added to DEPS:
'+google/cacheinvalidation/types.pb.h',
Presubmit checks took 2.9s to calculate.
Test steps:
1. Verify that things still build via GYP (and unit tests pass).
$ GYP_DEFINES="use_goma=1 gomadir=... chromeos=1" gclient sync
$ ninja -C out/Debug -j 150 chrome unit_tests \
interactive_ui_tests browser_tests drive
$ out/Debug/unit_tests
2. Verify that things still builds via GN.
$ gn gen out/Default --args='target_os="chromeos" use_goma=true'
$ ninja -C out/Default -j 150 chrome unit_tests \
interactive_ui_tests browser_tests components/drive
TEST=Please see "Test steps" above.
BUG=257943, 498951
NOPRESUBMIT=true
Review URL: https://codereview.chromium.org/1190203002
Cr-Commit-Position: refs/heads/master@{#339512}
Diffstat (limited to 'chrome/browser/drive/dummy_drive_service.h')
-rw-r--r-- | chrome/browser/drive/dummy_drive_service.h | 166 |
1 files changed, 0 insertions, 166 deletions
diff --git a/chrome/browser/drive/dummy_drive_service.h b/chrome/browser/drive/dummy_drive_service.h deleted file mode 100644 index 338e44c..0000000 --- a/chrome/browser/drive/dummy_drive_service.h +++ /dev/null @@ -1,166 +0,0 @@ -// Copyright (c) 2012 The Chromium Authors. All rights reserved. -// Use of this source code is governed by a BSD-style license that can be -// found in the LICENSE file. - -#ifndef CHROME_BROWSER_DRIVE_DUMMY_DRIVE_SERVICE_H_ -#define CHROME_BROWSER_DRIVE_DUMMY_DRIVE_SERVICE_H_ - -#include <string> - -#include "chrome/browser/drive/drive_service_interface.h" -#include "google_apis/drive/auth_service_interface.h" - -namespace drive { - -// Dummy implementation of DriveServiceInterface. -// All functions do nothing, or return place holder values like 'true'. -class DummyDriveService : public DriveServiceInterface { - public: - DummyDriveService(); - ~DummyDriveService() override; - - // DriveServiceInterface Overrides - void Initialize(const std::string& account_id) override; - void AddObserver(DriveServiceObserver* observer) override; - void RemoveObserver(DriveServiceObserver* observer) override; - bool CanSendRequest() const override; - bool HasAccessToken() const override; - void RequestAccessToken( - const google_apis::AuthStatusCallback& callback) override; - bool HasRefreshToken() const override; - void ClearAccessToken() override; - void ClearRefreshToken() override; - std::string GetRootResourceId() const override; - google_apis::CancelCallback GetAllFileList( - const google_apis::FileListCallback& callback) override; - google_apis::CancelCallback GetFileListInDirectory( - const std::string& directory_resource_id, - const google_apis::FileListCallback& callback) override; - google_apis::CancelCallback Search( - const std::string& search_query, - const google_apis::FileListCallback& callback) override; - google_apis::CancelCallback SearchByTitle( - const std::string& title, - const std::string& directory_resource_id, - const google_apis::FileListCallback& callback) override; - google_apis::CancelCallback GetChangeList( - int64 start_changestamp, - const google_apis::ChangeListCallback& callback) override; - google_apis::CancelCallback GetRemainingChangeList( - const GURL& next_link, - const google_apis::ChangeListCallback& callback) override; - google_apis::CancelCallback GetRemainingFileList( - const GURL& next_link, - const google_apis::FileListCallback& callback) override; - google_apis::CancelCallback GetFileResource( - const std::string& resource_id, - const google_apis::FileResourceCallback& callback) override; - google_apis::CancelCallback GetShareUrl( - const std::string& resource_id, - const GURL& embed_origin, - const google_apis::GetShareUrlCallback& callback) override; - google_apis::CancelCallback GetAboutResource( - const google_apis::AboutResourceCallback& callback) override; - google_apis::CancelCallback GetAppList( - const google_apis::AppListCallback& callback) override; - google_apis::CancelCallback DeleteResource( - const std::string& resource_id, - const std::string& etag, - const google_apis::EntryActionCallback& callback) override; - google_apis::CancelCallback TrashResource( - const std::string& resource_id, - const google_apis::EntryActionCallback& callback) override; - google_apis::CancelCallback DownloadFile( - const base::FilePath& local_cache_path, - const std::string& resource_id, - const google_apis::DownloadActionCallback& download_action_callback, - const google_apis::GetContentCallback& get_content_callback, - const google_apis::ProgressCallback& progress_callback) override; - google_apis::CancelCallback CopyResource( - const std::string& resource_id, - const std::string& parent_resource_id, - const std::string& new_title, - const base::Time& last_modified, - const google_apis::FileResourceCallback& callback) override; - google_apis::CancelCallback UpdateResource( - const std::string& resource_id, - const std::string& parent_resource_id, - const std::string& new_title, - const base::Time& last_modified, - const base::Time& last_viewed_by_me, - const google_apis::drive::Properties& properties, - const google_apis::FileResourceCallback& callback) override; - google_apis::CancelCallback AddResourceToDirectory( - const std::string& parent_resource_id, - const std::string& resource_id, - const google_apis::EntryActionCallback& callback) override; - google_apis::CancelCallback RemoveResourceFromDirectory( - const std::string& parent_resource_id, - const std::string& resource_id, - const google_apis::EntryActionCallback& callback) override; - google_apis::CancelCallback AddNewDirectory( - const std::string& parent_resource_id, - const std::string& directory_title, - const AddNewDirectoryOptions& options, - const google_apis::FileResourceCallback& callback) override; - google_apis::CancelCallback InitiateUploadNewFile( - const std::string& content_type, - int64 content_length, - const std::string& parent_resource_id, - const std::string& title, - const UploadNewFileOptions& options, - const google_apis::InitiateUploadCallback& callback) override; - google_apis::CancelCallback InitiateUploadExistingFile( - const std::string& content_type, - int64 content_length, - const std::string& resource_id, - const UploadExistingFileOptions& options, - const google_apis::InitiateUploadCallback& callback) override; - google_apis::CancelCallback ResumeUpload( - const GURL& upload_url, - int64 start_position, - int64 end_position, - int64 content_length, - const std::string& content_type, - const base::FilePath& local_file_path, - const google_apis::drive::UploadRangeCallback& callback, - const google_apis::ProgressCallback& progress_callback) override; - google_apis::CancelCallback GetUploadStatus( - const GURL& upload_url, - int64 content_length, - const google_apis::drive::UploadRangeCallback& callback) override; - google_apis::CancelCallback MultipartUploadNewFile( - const std::string& content_type, - int64 content_length, - const std::string& parent_resource_id, - const std::string& title, - const base::FilePath& local_file_path, - const UploadNewFileOptions& options, - const google_apis::FileResourceCallback& callback, - const google_apis::ProgressCallback& progress_callback) override; - google_apis::CancelCallback MultipartUploadExistingFile( - const std::string& content_type, - int64 content_length, - const std::string& resource_id, - const base::FilePath& local_file_path, - const UploadExistingFileOptions& options, - const google_apis::FileResourceCallback& callback, - const google_apis::ProgressCallback& progress_callback) override; - google_apis::CancelCallback AuthorizeApp( - const std::string& resource_id, - const std::string& app_id, - const google_apis::AuthorizeAppCallback& callback) override; - google_apis::CancelCallback UninstallApp( - const std::string& app_id, - const google_apis::EntryActionCallback& callback) override; - google_apis::CancelCallback AddPermission( - const std::string& resource_id, - const std::string& email, - google_apis::drive::PermissionRole role, - const google_apis::EntryActionCallback& callback) override; - scoped_ptr<BatchRequestConfiguratorInterface> StartBatchRequest() override; -}; - -} // namespace drive - -#endif // CHROME_BROWSER_DRIVE_DUMMY_DRIVE_SERVICE_H_ |