summaryrefslogtreecommitdiffstats
path: root/chrome/browser/enumerate_modules_model_win.cc
diff options
context:
space:
mode:
authorfinnur@chromium.org <finnur@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2010-11-24 15:41:17 +0000
committerfinnur@chromium.org <finnur@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2010-11-24 15:41:17 +0000
commitce8a9ca8389aa6a39c5622653e4ff9266cc0be18 (patch)
tree26c736ed665dedfea7c7c8e28bedea79d36b4d0a /chrome/browser/enumerate_modules_model_win.cc
parent5b811ad2f12a21e218e92d1498f972a4c95ce68d (diff)
downloadchromium_src-ce8a9ca8389aa6a39c5622653e4ff9266cc0be18.zip
chromium_src-ce8a9ca8389aa6a39c5622653e4ff9266cc0be18.tar.gz
chromium_src-ce8a9ca8389aa6a39c5622653e4ff9266cc0be18.tar.bz2
Readd two dlls to the blacklist for demonstration purposes.
To be removed shortly. TBR=huanr BUG=None TEST=None Review URL: http://codereview.chromium.org/5310004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67266 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/browser/enumerate_modules_model_win.cc')
-rw-r--r--chrome/browser/enumerate_modules_model_win.cc14
1 files changed, 11 insertions, 3 deletions
diff --git a/chrome/browser/enumerate_modules_model_win.cc b/chrome/browser/enumerate_modules_model_win.cc
index 9645d3c..5f72312 100644
--- a/chrome/browser/enumerate_modules_model_win.cc
+++ b/chrome/browser/enumerate_modules_model_win.cc
@@ -61,10 +61,11 @@ struct FindModule {
public:
explicit FindModule(const ModuleEnumerator::Module& x)
: module(x) {}
- bool operator()(ModuleEnumerator::Module module_in) const {
+ // Coverity issue 13896.
+ bool operator()(const ModuleEnumerator::Module& module_in) const {
return (module.type == module_in.type) &&
- (module.location == module_in.location) &&
- (module.name == module_in.name);
+ (module.location == module_in.location) &&
+ (module.name == module_in.name);
}
const ModuleEnumerator::Module& module;
@@ -83,6 +84,13 @@ struct FindModule {
// Entries without any Description, Signer info, or Location will never be
// marked as confirmed bad (only as suspicious).
const ModuleEnumerator::BlacklistEntry ModuleEnumerator::kModuleBlacklist[] = {
+ // Test DLLs, to demonstrate the feature. Will be removed soon.
+ { // apphelp.dll, "%systemroot%\\system32\\"
+ "f5fda581", "23d01d5b", "", "", "", NONE
+ }, { // rsaenh.dll, "%systemroot%\\system32\\", "Microsoft Windows"
+ "6af212cb", "23d01d5b", "7b47bf79", "", "",
+ static_cast<RecommendedAction>(UPDATE | DISABLE | SEE_LINK)
+ },
// NOTE: Please keep this list sorted by dll name, then location.