diff options
| author | oshima <oshima@chromium.org> | 2014-10-24 07:14:32 -0700 |
|---|---|---|
| committer | Commit bot <commit-bot@chromium.org> | 2014-10-24 14:14:55 +0000 |
| commit | 82f7248c0e48ee71c4b78f9d305caefc7fa9bab2 (patch) | |
| tree | 9ecd0cbb7fbb60805d3d82a466a969558632093e /chrome/browser/extensions/alert_apitest.cc | |
| parent | 2a1a687a8175495a41f32df456b03c227059616b (diff) | |
| download | chromium_src-82f7248c0e48ee71c4b78f9d305caefc7fa9bab2.zip chromium_src-82f7248c0e48ee71c4b78f9d305caefc7fa9bab2.tar.gz chromium_src-82f7248c0e48ee71c4b78f9d305caefc7fa9bab2.tar.bz2 | |
Componentize app_modal_dialog
Notable changes (other than just moving code aruond)
* kJavaScriptMessageExpectedDelay constant has been moved from chrome_constants to javascript_dialog_manager.cc because that's the only place used.
* NOTIFICATION_APP_MODAL_DIALOG_SHOWN notification has been removed and replaced by test only waiter class. (as this notification was used only in tests)
* Moved and creates string resource for app_modal_dialog.
Next step: move dialog implementations to compoents/app_modal_dialogs (javascript_dialog_manager/ javascript_app_modal_dialogs_views/, javascript_app_modal_dialogs_cocoa ....)
BUG=422092
TBR=sky@chromium.org
Review URL: https://codereview.chromium.org/648833004
Cr-Commit-Position: refs/heads/master@{#301095}
Diffstat (limited to 'chrome/browser/extensions/alert_apitest.cc')
| -rw-r--r-- | chrome/browser/extensions/alert_apitest.cc | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/chrome/browser/extensions/alert_apitest.cc b/chrome/browser/extensions/alert_apitest.cc index 893a9b4..dbd7c55 100644 --- a/chrome/browser/extensions/alert_apitest.cc +++ b/chrome/browser/extensions/alert_apitest.cc @@ -5,9 +5,9 @@ #include "base/strings/utf_string_conversions.h" #include "chrome/browser/extensions/extension_apitest.h" #include "chrome/browser/profiles/profile.h" -#include "chrome/browser/ui/app_modal_dialogs/app_modal_dialog.h" #include "chrome/browser/ui/browser.h" #include "chrome/test/base/ui_test_utils.h" +#include "components/app_modal_dialogs/app_modal_dialog.h" #include "content/public/browser/render_frame_host.h" #include "extensions/browser/extension_host.h" #include "extensions/browser/extension_system.h" |