diff options
| author | dgozman@chromium.org <dgozman@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2014-01-16 20:37:43 +0000 |
|---|---|---|
| committer | dgozman@chromium.org <dgozman@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2014-01-16 20:37:43 +0000 |
| commit | b9c5d50bfb6f29945cfa85e266f424379af771aa (patch) | |
| tree | 34fb370593b344948a97dc1e898d14df29365634 /chrome/browser/extensions/api/app_window | |
| parent | c73ec8abdd625a0ef63aba909884c632896ce4d9 (diff) | |
| download | chromium_src-b9c5d50bfb6f29945cfa85e266f424379af771aa.zip chromium_src-b9c5d50bfb6f29945cfa85e266f424379af771aa.tar.gz chromium_src-b9c5d50bfb6f29945cfa85e266f424379af771aa.tar.bz2 | |
[DevTools] Remove dock side knowledge from browser.
After this change, DevToolsWindow waits for frontend to decide
on dock side, and only then shows it either docked or undocked.
This also cleans up DevToolsWindow public API, so clients don't use
test function, and test clients are explicit with their docking expectations.
Note: follow up patch on frontend side is require to switch
from SetDockSide to SetIsDocked call.
BUG=318751
Review URL: https://codereview.chromium.org/108213012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245308 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/browser/extensions/api/app_window')
| -rw-r--r-- | chrome/browser/extensions/api/app_window/app_window_api.cc | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/chrome/browser/extensions/api/app_window/app_window_api.cc b/chrome/browser/extensions/api/app_window/app_window_api.cc index bb171c0..2d29e34 100644 --- a/chrome/browser/extensions/api/app_window/app_window_api.cc +++ b/chrome/browser/extensions/api/app_window/app_window_api.cc @@ -63,9 +63,8 @@ class DevToolsRestorer : public content::NotificationObserver { content::RenderViewHost* created_view) : delayed_create_function_(delayed_create_function) { DevToolsWindow* devtools_window = - DevToolsWindow::ToggleDevToolsWindow( + DevToolsWindow::OpenDevToolsWindow( created_view, - true /* force_open */, DevToolsToggleAction::ShowConsole()); registrar_.Add( |