diff options
| author | ben@chromium.org <ben@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2012-07-25 20:14:29 +0000 |
|---|---|---|
| committer | ben@chromium.org <ben@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2012-07-25 20:14:29 +0000 |
| commit | a4fe67013ea54ca4f550d8c27b55b180fe0c4a70 (patch) | |
| tree | a2eb4697a22a3ea49aeece7a395286a6e84fda0f /chrome/browser/extensions/api/extension_action | |
| parent | f82480eb8c899f51177505494a485587c60e7ad4 (diff) | |
| download | chromium_src-a4fe67013ea54ca4f550d8c27b55b180fe0c4a70.zip chromium_src-a4fe67013ea54ca4f550d8c27b55b180fe0c4a70.tar.gz chromium_src-a4fe67013ea54ca4f550d8c27b55b180fe0c4a70.tar.bz2 | |
Consolidate Browser Creation.
. Make all instantiators use a single ctor that takes CreateParams.
. Get rid of InitBrowserWindow() and make CreateBrowserWindow() a anonymous namespace function in browser.cc
http://crbug.com/133576
TEST=none
Review URL: https://chromiumcodereview.appspot.com/10692195
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148396 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/browser/extensions/api/extension_action')
| -rw-r--r-- | chrome/browser/extensions/api/extension_action/browser_action_apitest.cc | 8 |
1 files changed, 5 insertions, 3 deletions
diff --git a/chrome/browser/extensions/api/extension_action/browser_action_apitest.cc b/chrome/browser/extensions/api/extension_action/browser_action_apitest.cc index 3d2bbe2..13e46a8 100644 --- a/chrome/browser/extensions/api/extension_action/browser_action_apitest.cc +++ b/chrome/browser/extensions/api/extension_action/browser_action_apitest.cc @@ -295,7 +295,8 @@ IN_PROC_BROWSER_TEST_F(BrowserActionApiTest, IncognitoBasic) { // Open an incognito window and test that the browser action isn't there by // default. Profile* incognito_profile = browser()->profile()->GetOffTheRecordProfile(); - Browser* incognito_browser = Browser::Create(incognito_profile); + Browser* incognito_browser = + new Browser(Browser::CreateParams(incognito_profile)); ASSERT_EQ(0, BrowserActionTestUtil(incognito_browser).NumberOfBrowserActions()); @@ -307,7 +308,7 @@ IN_PROC_BROWSER_TEST_F(BrowserActionApiTest, IncognitoBasic) { SetIsIncognitoEnabled(extension->id(), true); chrome::CloseWindow(incognito_browser); - incognito_browser = Browser::Create(incognito_profile); + incognito_browser = new Browser(Browser::CreateParams(incognito_profile)); ASSERT_EQ(1, BrowserActionTestUtil(incognito_browser).NumberOfBrowserActions()); @@ -345,7 +346,8 @@ IN_PROC_BROWSER_TEST_F(BrowserActionApiTest, IncognitoDragging) { service->extension_prefs()->SetIsIncognitoEnabled(extension_c->id(), true); Profile* incognito_profile = browser()->profile()->GetOffTheRecordProfile(); - Browser* incognito_browser = Browser::Create(incognito_profile); + Browser* incognito_browser = + new Browser(Browser::CreateParams(incognito_profile)); BrowserActionTestUtil incognito_bar(incognito_browser); // Navigate just to have a tab in this window, otherwise wonky things happen. |