summaryrefslogtreecommitdiffstats
path: root/chrome/browser/extensions/api/management/management_api_browsertest.cc
diff options
context:
space:
mode:
authordcheng@chromium.org <dcheng@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2013-04-09 08:46:45 +0000
committerdcheng@chromium.org <dcheng@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2013-04-09 08:46:45 +0000
commit007b3f812fc9c989fb99d4a668d8bd9c7807ad81 (patch)
tree43e69dd0f4e4dbbe68afb6319fa18cee07a4be64 /chrome/browser/extensions/api/management/management_api_browsertest.cc
parent2bde7e94eb8f402839145e48924391a5c645a554 (diff)
downloadchromium_src-007b3f812fc9c989fb99d4a668d8bd9c7807ad81.zip
chromium_src-007b3f812fc9c989fb99d4a668d8bd9c7807ad81.tar.gz
chromium_src-007b3f812fc9c989fb99d4a668d8bd9c7807ad81.tar.bz2
Rewrite std::string("") to std::string(), Linux edition.
This patch was generated by running the empty_string clang tool across the Chromium Linux compilation database. Implicitly or explicitly constructing std::string() with a "" argument is inefficient as the caller needs to emit extra instructions to pass an argument, and the constructor needlessly copies a byte into internal storage. Rewriting these instances to simply call the default constructor appears to save ~14-18 kilobytes on an optimized release build. BUG=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=193020 Review URL: https://codereview.chromium.org/13145003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@193040 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/browser/extensions/api/management/management_api_browsertest.cc')
-rw-r--r--chrome/browser/extensions/api/management/management_api_browsertest.cc10
1 files changed, 5 insertions, 5 deletions
diff --git a/chrome/browser/extensions/api/management/management_api_browsertest.cc b/chrome/browser/extensions/api/management/management_api_browsertest.cc
index f475e81..5b6b04d 100644
--- a/chrome/browser/extensions/api/management/management_api_browsertest.cc
+++ b/chrome/browser/extensions/api/management/management_api_browsertest.cc
@@ -257,15 +257,15 @@ IN_PROC_BROWSER_TEST_F(ExtensionManagementApiEscalationTest,
// This should succeed when user accepts dialog.
CommandLine::ForCurrentProcess()->AppendSwitchASCII(
switches::kAppsGalleryInstallAutoConfirmForTests, "accept");
- SetEnabled(true, true, "");
+ SetEnabled(true, true, std::string());
// Crash the extension. Mock a reload by disabling and then enabling. The
// extension should be reloaded and enabled.
ASSERT_TRUE(CrashEnabledExtension(kId));
- SetEnabled(false, true, "");
- SetEnabled(true, true, "");
- const Extension* extension = ExtensionSystem::Get(browser()->profile())->
- extension_service()->GetExtensionById(kId, false);
+ SetEnabled(false, true, std::string());
+ SetEnabled(true, true, std::string());
+ const Extension* extension = ExtensionSystem::Get(browser()->profile())
+ ->extension_service()->GetExtensionById(kId, false);
EXPECT_TRUE(extension);
}