diff options
author | kalman@chromium.org <kalman@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2014-04-30 05:20:08 +0000 |
---|---|---|
committer | kalman@chromium.org <kalman@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2014-04-30 05:20:08 +0000 |
commit | 533ef3d365c29ff78439edc6acf7e0ba3803bf26 (patch) | |
tree | 5d6e30a217673dea7fb649fb7af5c76c46a44033 /chrome/browser/extensions/api/web_navigation | |
parent | ac9142eab1d80e2e8da9c827772ac6157e35d804 (diff) | |
download | chromium_src-533ef3d365c29ff78439edc6acf7e0ba3803bf26.zip chromium_src-533ef3d365c29ff78439edc6acf7e0ba3803bf26.tar.gz chromium_src-533ef3d365c29ff78439edc6acf7e0ba3803bf26.tar.bz2 |
Rename (Chrome)SyncExtensionFunction::RunImpl to RunSync so that the RunImpl
function doesn't require divergent return value semantics depending on subclass.
BUG=365732
R=rockot@chromium.org
TBR=pkasting@chromium.org,dtseng@chromium.org
Review URL: https://codereview.chromium.org/252653002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@267083 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/browser/extensions/api/web_navigation')
-rw-r--r-- | chrome/browser/extensions/api/web_navigation/web_navigation_api.cc | 4 | ||||
-rw-r--r-- | chrome/browser/extensions/api/web_navigation/web_navigation_api.h | 4 |
2 files changed, 4 insertions, 4 deletions
diff --git a/chrome/browser/extensions/api/web_navigation/web_navigation_api.cc b/chrome/browser/extensions/api/web_navigation/web_navigation_api.cc index f41c1b1..a1902e9 100644 --- a/chrome/browser/extensions/api/web_navigation/web_navigation_api.cc +++ b/chrome/browser/extensions/api/web_navigation/web_navigation_api.cc @@ -690,7 +690,7 @@ bool WebNavigationTabObserver::IsReferenceFragmentNavigation( url.ReplaceComponents(replacements); } -bool WebNavigationGetFrameFunction::RunImpl() { +bool WebNavigationGetFrameFunction::RunSync() { scoped_ptr<GetFrame::Params> params(GetFrame::Params::Create(*args_)); EXTENSION_FUNCTION_VALIDATE(params.get()); int tab_id = params->details.tab_id; @@ -747,7 +747,7 @@ bool WebNavigationGetFrameFunction::RunImpl() { return true; } -bool WebNavigationGetAllFramesFunction::RunImpl() { +bool WebNavigationGetAllFramesFunction::RunSync() { scoped_ptr<GetAllFrames::Params> params(GetAllFrames::Params::Create(*args_)); EXTENSION_FUNCTION_VALIDATE(params.get()); int tab_id = params->details.tab_id; diff --git a/chrome/browser/extensions/api/web_navigation/web_navigation_api.h b/chrome/browser/extensions/api/web_navigation/web_navigation_api.h index 49d70c0..d3aaf76 100644 --- a/chrome/browser/extensions/api/web_navigation/web_navigation_api.h +++ b/chrome/browser/extensions/api/web_navigation/web_navigation_api.h @@ -211,14 +211,14 @@ class WebNavigationEventRouter : public TabStripModelObserver, // API function that returns the state of a given frame. class WebNavigationGetFrameFunction : public ChromeSyncExtensionFunction { virtual ~WebNavigationGetFrameFunction() {} - virtual bool RunImpl() OVERRIDE; + virtual bool RunSync() OVERRIDE; DECLARE_EXTENSION_FUNCTION("webNavigation.getFrame", WEBNAVIGATION_GETFRAME) }; // API function that returns the states of all frames in a given tab. class WebNavigationGetAllFramesFunction : public ChromeSyncExtensionFunction { virtual ~WebNavigationGetAllFramesFunction() {} - virtual bool RunImpl() OVERRIDE; + virtual bool RunSync() OVERRIDE; DECLARE_EXTENSION_FUNCTION("webNavigation.getAllFrames", WEBNAVIGATION_GETALLFRAMES) }; |