diff options
author | scherkus@chromium.org <scherkus@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2014-01-07 21:40:50 +0000 |
---|---|---|
committer | scherkus@chromium.org <scherkus@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2014-01-07 21:40:50 +0000 |
commit | a0e7e86682f9804b06d59d9163f8118484e30c91 (patch) | |
tree | 2d85734289e5b6dfdf54c24c5de5d8e3f8e0eb39 /chrome/browser/extensions/api/webrtc_audio_private | |
parent | b2a34d53b43b5c81b36d9c40caeed8353bb3c433 (diff) | |
download | chromium_src-a0e7e86682f9804b06d59d9163f8118484e30c91.zip chromium_src-a0e7e86682f9804b06d59d9163f8118484e30c91.tar.gz chromium_src-a0e7e86682f9804b06d59d9163f8118484e30c91.tar.bz2 |
Replace MessageLoopProxy with SingleThreadTaskRunner for the rest of media/.
BUG=315922
R=dalecurtis@chromium.org
TBR=jam
Review URL: https://codereview.chromium.org/66183002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243390 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/browser/extensions/api/webrtc_audio_private')
3 files changed, 13 insertions, 15 deletions
diff --git a/chrome/browser/extensions/api/webrtc_audio_private/webrtc_audio_private_api.cc b/chrome/browser/extensions/api/webrtc_audio_private/webrtc_audio_private_api.cc index 4725c5d..5cc59fc 100644 --- a/chrome/browser/extensions/api/webrtc_audio_private/webrtc_audio_private_api.cc +++ b/chrome/browser/extensions/api/webrtc_audio_private/webrtc_audio_private_api.cc @@ -5,7 +5,6 @@ #include "chrome/browser/extensions/api/webrtc_audio_private/webrtc_audio_private_api.h" #include "base/lazy_instance.h" -#include "base/message_loop/message_loop_proxy.h" #include "base/strings/string_number_conversions.h" #include "base/task_runner_util.h" #include "chrome/browser/extensions/api/tabs/tabs_constants.h" @@ -99,7 +98,7 @@ void WebrtcAudioPrivateEventService::SignalEvent() { bool WebrtcAudioPrivateGetSinksFunction::RunImpl() { DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI)); - AudioManager::Get()->GetMessageLoop()->PostTaskAndReply( + AudioManager::Get()->GetTaskRunner()->PostTaskAndReply( FROM_HERE, base::Bind(&WebrtcAudioPrivateGetSinksFunction::DoQuery, this), base::Bind(&WebrtcAudioPrivateGetSinksFunction::DoneOnUIThread, this)); @@ -107,7 +106,7 @@ bool WebrtcAudioPrivateGetSinksFunction::RunImpl() { } void WebrtcAudioPrivateGetSinksFunction::DoQuery() { - DCHECK(AudioManager::Get()->GetMessageLoop()->BelongsToCurrentThread()); + DCHECK(AudioManager::Get()->GetTaskRunner()->BelongsToCurrentThread()); AudioDeviceNames device_names; AudioManager::Get()->GetAudioOutputDeviceNames(&device_names); @@ -198,7 +197,7 @@ void WebrtcAudioPrivateGetActiveSinkFunction::OnSinkId(const std::string& id) { WebrtcAudioPrivateSetActiveSinkFunction:: WebrtcAudioPrivateSetActiveSinkFunction() - : message_loop_(base::MessageLoopProxy::current()), + : task_runner_(base::MessageLoopProxy::current()), tab_id_(0), num_remaining_sink_ids_(0) { } @@ -244,7 +243,7 @@ void WebrtcAudioPrivateSetActiveSinkFunction::OnControllerList( void WebrtcAudioPrivateSetActiveSinkFunction::SwitchDone() { if (--num_remaining_sink_ids_ == 0) { - message_loop_->PostTask( + task_runner_->PostTask( FROM_HERE, base::Bind(&WebrtcAudioPrivateSetActiveSinkFunction::DoneOnUIThread, this)); @@ -268,7 +267,7 @@ bool WebrtcAudioPrivateGetAssociatedSinkFunction::RunImpl() { DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI)); EXTENSION_FUNCTION_VALIDATE(params_.get()); - AudioManager::Get()->GetMessageLoop()->PostTaskAndReply( + AudioManager::Get()->GetTaskRunner()->PostTaskAndReply( FROM_HERE, base::Bind(&WebrtcAudioPrivateGetAssociatedSinkFunction:: GetDevicesOnDeviceThread, this), @@ -280,7 +279,7 @@ bool WebrtcAudioPrivateGetAssociatedSinkFunction::RunImpl() { } void WebrtcAudioPrivateGetAssociatedSinkFunction::GetDevicesOnDeviceThread() { - DCHECK(AudioManager::Get()->GetMessageLoop()->BelongsToCurrentThread()); + DCHECK(AudioManager::Get()->GetTaskRunner()->BelongsToCurrentThread()); AudioManager::Get()->GetAudioInputDeviceNames(&source_devices_); } @@ -332,7 +331,7 @@ void WebrtcAudioPrivateGetAssociatedSinkFunction::OnGetRawSourceIDDone( const std::string& raw_source_id) { DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI)); base::PostTaskAndReplyWithResult( - AudioManager::Get()->GetMessageLoop(), + AudioManager::Get()->GetTaskRunner(), FROM_HERE, base::Bind(&WebrtcAudioPrivateGetAssociatedSinkFunction:: GetAssociatedSinkOnDeviceThread, @@ -346,7 +345,7 @@ void WebrtcAudioPrivateGetAssociatedSinkFunction::OnGetRawSourceIDDone( std::string WebrtcAudioPrivateGetAssociatedSinkFunction::GetAssociatedSinkOnDeviceThread( const std::string& raw_source_id) { - DCHECK(AudioManager::Get()->GetMessageLoop()->BelongsToCurrentThread()); + DCHECK(AudioManager::Get()->GetTaskRunner()->BelongsToCurrentThread()); // We return an empty string if there is no associated output device. std::string result; diff --git a/chrome/browser/extensions/api/webrtc_audio_private/webrtc_audio_private_api.h b/chrome/browser/extensions/api/webrtc_audio_private/webrtc_audio_private_api.h index cf3a994..85f1922 100644 --- a/chrome/browser/extensions/api/webrtc_audio_private/webrtc_audio_private_api.h +++ b/chrome/browser/extensions/api/webrtc_audio_private/webrtc_audio_private_api.h @@ -16,7 +16,7 @@ #include "url/gurl.h" namespace base { -class MessageLoopProxy; +class SingleThreadTaskRunner; } namespace extensions { @@ -107,8 +107,8 @@ class WebrtcAudioPrivateSetActiveSinkFunction void SwitchDone(); void DoneOnUIThread(); - // Message loop of the thread this class is constructed on. - const scoped_refptr<base::MessageLoopProxy> message_loop_; + // Task runner of the thread this class is constructed on. + const scoped_refptr<base::SingleThreadTaskRunner> task_runner_; int tab_id_; std::string sink_id_; diff --git a/chrome/browser/extensions/api/webrtc_audio_private/webrtc_audio_private_browsertest.cc b/chrome/browser/extensions/api/webrtc_audio_private/webrtc_audio_private_browsertest.cc index abb18c1..57480f8 100644 --- a/chrome/browser/extensions/api/webrtc_audio_private/webrtc_audio_private_browsertest.cc +++ b/chrome/browser/extensions/api/webrtc_audio_private/webrtc_audio_private_browsertest.cc @@ -3,7 +3,6 @@ // found in the LICENSE file. #include "base/json/json_writer.h" -#include "base/message_loop/message_loop.h" #include "base/strings/string_util.h" #include "base/strings/stringprintf.h" #include "base/strings/utf_string_conversions.h" @@ -103,8 +102,8 @@ class WebrtcAudioPrivateTest : public AudioWaitingExtensionTest { AudioDeviceNames* device_names) { AudioManager* audio_manager = AudioManager::Get(); - if (!audio_manager->GetMessageLoop()->BelongsToCurrentThread()) { - audio_manager->GetMessageLoop()->PostTask( + if (!audio_manager->GetTaskRunner()->BelongsToCurrentThread()) { + audio_manager->GetTaskRunner()->PostTask( FROM_HERE, base::Bind(&WebrtcAudioPrivateTest::GetAudioDeviceNames, this, EnumerationFunc, device_names)); |