diff options
| author | jamescook@chromium.org <jamescook@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2014-07-31 12:44:06 +0000 |
|---|---|---|
| committer | jamescook@chromium.org <jamescook@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2014-07-31 12:44:06 +0000 |
| commit | adf5a10eeb5dc230f27d3b1344f2111bdfcd97d6 (patch) | |
| tree | 8ba5fbfcb3ddaa54355fa3b03cbdcadcbc6d875d /chrome/browser/extensions/bookmark_app_helper.cc | |
| parent | 248ee9be3db637800a1bf7b13817df43f904248b (diff) | |
| download | chromium_src-adf5a10eeb5dc230f27d3b1344f2111bdfcd97d6.zip chromium_src-adf5a10eeb5dc230f27d3b1344f2111bdfcd97d6.tar.gz chromium_src-adf5a10eeb5dc230f27d3b1344f2111bdfcd97d6.tar.bz2 | |
Move extension notifications to extensions/browser/notification_types.h
As part of the extensions module refactor we temporarily allowed the use
of chrome_notification_types.h in src/extensions. However, this allowed
code moving into src/extensions to listen to notifications from Chrome,
which was a layering violation.
This CL moves all the extensions notifications into their own header and
cleans up DEPS to disallow the exception.
BUG=392622
TEST=compiles, unit_tests, browser_tests, extensions_unittests
TBR=miket@chromium.org for apps/
Review URL: https://codereview.chromium.org/425303002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@286770 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/browser/extensions/bookmark_app_helper.cc')
| -rw-r--r-- | chrome/browser/extensions/bookmark_app_helper.cc | 10 |
1 files changed, 5 insertions, 5 deletions
diff --git a/chrome/browser/extensions/bookmark_app_helper.cc b/chrome/browser/extensions/bookmark_app_helper.cc index 1403470..c876524 100644 --- a/chrome/browser/extensions/bookmark_app_helper.cc +++ b/chrome/browser/extensions/bookmark_app_helper.cc @@ -7,7 +7,6 @@ #include <cctype> #include "base/strings/utf_string_conversions.h" -#include "chrome/browser/chrome_notification_types.h" #include "chrome/browser/extensions/crx_installer.h" #include "chrome/browser/extensions/extension_service.h" #include "chrome/browser/extensions/favicon_downloader.h" @@ -18,6 +17,7 @@ #include "content/public/browser/notification_source.h" #include "content/public/browser/web_contents.h" #include "extensions/browser/image_loader.h" +#include "extensions/browser/notification_types.h" #include "extensions/common/constants.h" #include "extensions/common/extension.h" #include "extensions/common/manifest_handlers/icons_handler.h" @@ -174,11 +174,11 @@ BookmarkAppHelper::BookmarkAppHelper(ExtensionService* service, : web_app_info_(web_app_info), crx_installer_(extensions::CrxInstaller::CreateSilent(service)) { registrar_.Add(this, - chrome::NOTIFICATION_CRX_INSTALLER_DONE, + extensions::NOTIFICATION_CRX_INSTALLER_DONE, content::Source<CrxInstaller>(crx_installer_.get())); registrar_.Add(this, - chrome::NOTIFICATION_EXTENSION_INSTALL_ERROR, + extensions::NOTIFICATION_EXTENSION_INSTALL_ERROR, content::Source<CrxInstaller>(crx_installer_.get())); crx_installer_->set_error_on_unsupported_requirements(true); @@ -330,7 +330,7 @@ void BookmarkAppHelper::Observe(int type, const content::NotificationSource& source, const content::NotificationDetails& details) { switch (type) { - case chrome::NOTIFICATION_CRX_INSTALLER_DONE: { + case extensions::NOTIFICATION_CRX_INSTALLER_DONE: { const Extension* extension = content::Details<const Extension>(details).ptr(); DCHECK(extension); @@ -339,7 +339,7 @@ void BookmarkAppHelper::Observe(int type, callback_.Run(extension, web_app_info_); break; } - case chrome::NOTIFICATION_EXTENSION_INSTALL_ERROR: + case extensions::NOTIFICATION_EXTENSION_INSTALL_ERROR: callback_.Run(NULL, web_app_info_); break; default: |