diff options
| author | pkasting@chromium.org <pkasting@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2014-07-10 20:30:12 +0000 |
|---|---|---|
| committer | pkasting@chromium.org <pkasting@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2014-07-10 20:30:12 +0000 |
| commit | 93ea1882c8b7e60e6325d67be11aecc61cdd4e9b (patch) | |
| tree | e2136cd9c31c40ee0034d15aacd87eff6e2da14b /chrome/browser/extensions/data_deleter.cc | |
| parent | 19e89d483c8c93eaa7e7038bfef8c626d1572bc3 (diff) | |
| download | chromium_src-93ea1882c8b7e60e6325d67be11aecc61cdd4e9b.zip chromium_src-93ea1882c8b7e60e6325d67be11aecc61cdd4e9b.tar.gz chromium_src-93ea1882c8b7e60e6325d67be11aecc61cdd4e9b.tar.bz2 | |
Fixes for re-enabling more MSVC level 4 warnings: misc edition #1
This contains fixes for the following sorts of issues:
* Signedness mismatch
The problem here is that using enums to declare bitmasks results in the enum values being signed, when all consumers want to use the values in an unsigned context. Declaring them as consts allows using the more appropriate uint32 type.
In C++11 we could use "enum class" for this, but C++11 isn't legal yet.
BUG=81439
TEST=none
Review URL: https://codereview.chromium.org/385443002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282419 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/browser/extensions/data_deleter.cc')
| -rw-r--r-- | chrome/browser/extensions/data_deleter.cc | 6 |
1 files changed, 2 insertions, 4 deletions
diff --git a/chrome/browser/extensions/data_deleter.cc b/chrome/browser/extensions/data_deleter.cc index 9d8ffb7..b28e7b2 100644 --- a/chrome/browser/extensions/data_deleter.cc +++ b/chrome/browser/extensions/data_deleter.cc @@ -53,8 +53,7 @@ void DeleteOrigin(Profile* profile, // simpler than special casing. This code should go away once we merge // the various URLRequestContexts (http://crbug.com/159193). partition->ClearDataForOrigin( - StoragePartition::REMOVE_DATA_MASK_ALL & - (~StoragePartition::REMOVE_DATA_MASK_SHADER_CACHE), + ~StoragePartition::REMOVE_DATA_MASK_SHADER_CACHE, StoragePartition::QUOTA_MANAGED_STORAGE_MASK_ALL, origin, profile->GetRequestContextForExtensions()); @@ -62,8 +61,7 @@ void DeleteOrigin(Profile* profile, // We don't need to worry about the media request context because that // shares the same cookie store as the main request context. partition->ClearDataForOrigin( - StoragePartition::REMOVE_DATA_MASK_ALL & - (~StoragePartition::REMOVE_DATA_MASK_SHADER_CACHE), + ~StoragePartition::REMOVE_DATA_MASK_SHADER_CACHE, StoragePartition::QUOTA_MANAGED_STORAGE_MASK_ALL, origin, partition->GetURLRequestContext()); |