diff options
| author | rdevlin.cronin <rdevlin.cronin@chromium.org> | 2015-04-29 09:51:43 -0700 |
|---|---|---|
| committer | Commit bot <commit-bot@chromium.org> | 2015-04-29 16:53:03 +0000 |
| commit | 20bf10bc2f45275a9473b8121447b44810bb4909 (patch) | |
| tree | 85fe91142ca92a443d245b94c3d5829bfc436010 /chrome/browser/extensions/error_console/error_console.h | |
| parent | ccb7359c4a7948b3a7a639342037b856de9fe82c (diff) | |
| download | chromium_src-20bf10bc2f45275a9473b8121447b44810bb4909.zip chromium_src-20bf10bc2f45275a9473b8121447b44810bb4909.tar.gz chromium_src-20bf10bc2f45275a9473b8121447b44810bb4909.tar.bz2 | |
[Extensions] Update Error Console UI
The current Error Console UI is a little lacking. Most egregiously, there's no
way to clear errors. Update the UI by moving more of the error console into its
dedicated overlay, which
- Minimizes its footprint on the main page.
- Makes it easy to switch between errors easily.
Additionally, add support for removing specific (or all) errors associated with
extensions.
Screenshots are up at
https://drive.google.com/open?id=0BxjK6_MzZ8UPfndZcElPVGxxdWxXQmN3WkVtSFhNUkN3SlFVYVQtaGlpWTJaOU52YTRfOGs&authuser=0
(Internal only for now; will post externally soon)
BUG=482526
Review URL: https://codereview.chromium.org/1016413004
Cr-Commit-Position: refs/heads/master@{#327509}
Diffstat (limited to 'chrome/browser/extensions/error_console/error_console.h')
| -rw-r--r-- | chrome/browser/extensions/error_console/error_console.h | 8 |
1 files changed, 7 insertions, 1 deletions
diff --git a/chrome/browser/extensions/error_console/error_console.h b/chrome/browser/extensions/error_console/error_console.h index 4d56308..006c31f4 100644 --- a/chrome/browser/extensions/error_console/error_console.h +++ b/chrome/browser/extensions/error_console/error_console.h @@ -42,7 +42,13 @@ class ErrorConsole : public content::NotificationObserver, class Observer { public: // Sent when a new error is reported to the error console. - virtual void OnErrorAdded(const ExtensionError* error) = 0; + virtual void OnErrorAdded(const ExtensionError* error); + + // Sent when errors are removed from the error console. |extension_ids| is + // the set of ids that were affected. + // Note: This is not sent when an extension is uninstalled, or when a + // profile is destroyed. + virtual void OnErrorsRemoved(const std::set<std::string>& extension_ids); // Sent upon destruction to allow any observers to invalidate any references // they have to the error console. |