summaryrefslogtreecommitdiffstats
path: root/chrome/browser/extensions/execute_script_apitest.cc
diff options
context:
space:
mode:
authorjstritar@chromium.org <jstritar@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2012-01-30 17:59:16 +0000
committerjstritar@chromium.org <jstritar@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2012-01-30 17:59:16 +0000
commitc107d49794a5ccf7c5cc8f8e27604782de57279b (patch)
tree7e5993a8f7371fab5ac6ac61f570658392e68e72 /chrome/browser/extensions/execute_script_apitest.cc
parent11713fd37bfee13bbc698190d939259ecff636f8 (diff)
downloadchromium_src-c107d49794a5ccf7c5cc8f8e27604782de57279b.zip
chromium_src-c107d49794a5ccf7c5cc8f8e27604782de57279b.tar.gz
chromium_src-c107d49794a5ccf7c5cc8f8e27604782de57279b.tar.bz2
Fix callback for chrome.tabs.update with javascript URLs.
UpdateTabFunction is asynchronous when updating a tab with a javascript URL. In this situation, the method was returning early before generating the callback result. This fixes the ExecuteScriptApiTest.NavigationRaceJavaScriptUrl test. BUG=89731 TEST=ExecuteScriptApiTest.NavigationRaceJavaScriptUrl Review URL: http://codereview.chromium.org/9225010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119690 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/browser/extensions/execute_script_apitest.cc')
-rw-r--r--chrome/browser/extensions/execute_script_apitest.cc13
1 files changed, 2 insertions, 11 deletions
diff --git a/chrome/browser/extensions/execute_script_apitest.cc b/chrome/browser/extensions/execute_script_apitest.cc
index ee8db03..3a5e92a 100644
--- a/chrome/browser/extensions/execute_script_apitest.cc
+++ b/chrome/browser/extensions/execute_script_apitest.cc
@@ -1,4 +1,4 @@
-// Copyright (c) 2011 The Chromium Authors. All rights reserved.
+// Copyright (c) 2012 The Chromium Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
@@ -77,16 +77,7 @@ IN_PROC_BROWSER_TEST_F(ExecuteScriptApiTest, NavigationRaceExecuteScript) {
"execute_script.html")) << message_;
}
-
-#if defined(OS_LINUX)
-// Fails on Linux. http://crbug.com/89731
-#define MAYBE_NavigationRaceJavaScriptUrl DISABLED_NavigationRaceJavaScriptUrl
-#else
-#define MAYBE_NavigationRaceJavaScriptUrl NavigationRaceJavaScriptUrl
-#endif
-
-IN_PROC_BROWSER_TEST_F(ExecuteScriptApiTest,
- MAYBE_NavigationRaceJavaScriptUrl) {
+IN_PROC_BROWSER_TEST_F(ExecuteScriptApiTest, NavigationRaceJavaScriptURL) {
host_resolver()->AddRule("a.com", "127.0.0.1");
host_resolver()->AddRule("b.com", "127.0.0.1");
ASSERT_TRUE(StartTestServer());