summaryrefslogtreecommitdiffstats
path: root/chrome/browser/extensions/extension_browser_event_router.h
diff options
context:
space:
mode:
authormihaip@chromium.org <mihaip@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2011-08-31 22:52:54 +0000
committermihaip@chromium.org <mihaip@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2011-08-31 22:52:54 +0000
commit1790275fe70ec6f824a34632f2101b5256e5d218 (patch)
tree9877f7b7c8b25d7d2a0d7444e3703614b39663a5 /chrome/browser/extensions/extension_browser_event_router.h
parentb32613252ab076e3ac26d7ecb1c5af383de64da1 (diff)
downloadchromium_src-1790275fe70ec6f824a34632f2101b5256e5d218.zip
chromium_src-1790275fe70ec6f824a34632f2101b5256e5d218.tar.gz
chromium_src-1790275fe70ec6f824a34632f2101b5256e5d218.tar.bz2
Remove obsolete TODO and add a bunch of OVERRIDEs.
R=aa@chromium.org Review URL: http://codereview.chromium.org/7806009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@99070 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/browser/extensions/extension_browser_event_router.h')
-rw-r--r--chrome/browser/extensions/extension_browser_event_router.h32
1 files changed, 17 insertions, 15 deletions
diff --git a/chrome/browser/extensions/extension_browser_event_router.h b/chrome/browser/extensions/extension_browser_event_router.h
index ddd878b..08e37a4 100644
--- a/chrome/browser/extensions/extension_browser_event_router.h
+++ b/chrome/browser/extensions/extension_browser_event_router.h
@@ -10,6 +10,7 @@
#include <string>
#include "base/basictypes.h"
+#include "base/compiler_specific.h"
#include "chrome/browser/extensions/extension_tabs_module.h"
#include "chrome/browser/tabs/tab_strip_model_observer.h"
#include "chrome/browser/ui/browser_list.h"
@@ -42,15 +43,15 @@ class ExtensionBrowserEventRouter : public TabStripModelObserver,
void Init();
// BrowserList::Observer
- virtual void OnBrowserAdded(const Browser* browser);
- virtual void OnBrowserRemoved(const Browser* browser);
- virtual void OnBrowserSetLastActive(const Browser* browser);
+ virtual void OnBrowserAdded(const Browser* browser) OVERRIDE;
+ virtual void OnBrowserRemoved(const Browser* browser) OVERRIDE;
+ virtual void OnBrowserSetLastActive(const Browser* browser) OVERRIDE;
#if defined(TOOLKIT_VIEWS)
virtual void NativeFocusWillChange(gfx::NativeView focused_before,
- gfx::NativeView focused_now);
+ gfx::NativeView focused_now) OVERRIDE;
#elif defined(TOOLKIT_GTK)
- virtual void ActiveWindowChanged(GdkWindow* active_window);
+ virtual void ActiveWindowChanged(GdkWindow* active_window) OVERRIDE;
#endif
// Called from Observe() on BROWSER_WINDOW_READY (not a part of
@@ -59,25 +60,26 @@ class ExtensionBrowserEventRouter : public TabStripModelObserver,
// TabStripModelObserver
virtual void TabInsertedAt(TabContentsWrapper* contents, int index,
- bool active);
+ bool active) OVERRIDE;
virtual void TabClosingAt(TabStripModel* tab_strip_model,
TabContentsWrapper* contents,
- int index);
- virtual void TabDetachedAt(TabContentsWrapper* contents, int index);
+ int index) OVERRIDE;
+ virtual void TabDetachedAt(TabContentsWrapper* contents, int index) OVERRIDE;
virtual void ActiveTabChanged(TabContentsWrapper* old_contents,
TabContentsWrapper* new_contents,
int index,
- bool user_gesture);
+ bool user_gesture) OVERRIDE;
virtual void TabMoved(TabContentsWrapper* contents, int from_index,
- int to_index);
+ int to_index) OVERRIDE;
virtual void TabChangedAt(TabContentsWrapper* contents, int index,
- TabChangeType change_type);
+ TabChangeType change_type) OVERRIDE;
virtual void TabReplacedAt(TabStripModel* tab_strip_model,
TabContentsWrapper* old_contents,
TabContentsWrapper* new_contents,
- int index);
- virtual void TabPinnedStateChanged(TabContentsWrapper* contents, int index);
- virtual void TabStripEmpty();
+ int index) OVERRIDE;
+ virtual void TabPinnedStateChanged(TabContentsWrapper* contents,
+ int index) OVERRIDE;
+ virtual void TabStripEmpty() OVERRIDE;
// Page Action execute event.
void PageActionExecuted(Profile* profile,
@@ -94,7 +96,7 @@ class ExtensionBrowserEventRouter : public TabStripModelObserver,
// NotificationObserver.
virtual void Observe(int type,
const NotificationSource& source,
- const NotificationDetails& details);
+ const NotificationDetails& details) OVERRIDE;
private:
// "Synthetic" event. Called from TabInsertedAt if new tab is detected.
void TabCreatedAt(TabContents* contents, int index, bool active);