diff options
| author | brettw@chromium.org <brettw@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-07-30 19:28:44 +0000 |
|---|---|---|
| committer | brettw@chromium.org <brettw@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-07-30 19:28:44 +0000 |
| commit | 528c56de01bbbd38788ed6cf8d2eea4c56cbe19e (patch) | |
| tree | ac4f7a001affd772c4ab89701d3d46109b5f9e19 /chrome/browser/extensions/extension_history_api.cc | |
| parent | 5c86ada8d84f6e67d17b027d347052ef451241c4 (diff) | |
| download | chromium_src-528c56de01bbbd38788ed6cf8d2eea4c56cbe19e.zip chromium_src-528c56de01bbbd38788ed6cf8d2eea4c56cbe19e.tar.gz chromium_src-528c56de01bbbd38788ed6cf8d2eea4c56cbe19e.tar.bz2 | |
Move the number conversions from string_util to a new file.
Use the base namespace in the new file. Update callers.
I removed all wstring variants and also the string->number ones that ignore the return value. That encourages people to write code and forget about error handling.
TEST=included unit tests
BUG=none
Review URL: http://codereview.chromium.org/3056029
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54355 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/browser/extensions/extension_history_api.cc')
| -rw-r--r-- | chrome/browser/extensions/extension_history_api.cc | 10 |
1 files changed, 5 insertions, 5 deletions
diff --git a/chrome/browser/extensions/extension_history_api.cc b/chrome/browser/extensions/extension_history_api.cc index 23f861f..0b891c8 100644 --- a/chrome/browser/extensions/extension_history_api.cc +++ b/chrome/browser/extensions/extension_history_api.cc @@ -7,7 +7,7 @@ #include "base/callback.h" #include "base/json/json_writer.h" #include "base/message_loop.h" -#include "base/string_util.h" +#include "base/string_number_conversions.h" #include "base/task.h" #include "base/values.h" #include "chrome/browser/extensions/extension_history_api_constants.h" @@ -28,7 +28,7 @@ double MilliSecondsFromTime(const base::Time& time) { void GetHistoryItemDictionary(const history::URLRow& row, DictionaryValue* value) { - value->SetString(keys::kIdKey, Int64ToString(row.id())); + value->SetString(keys::kIdKey, base::Int64ToString(row.id())); value->SetString(keys::kUrlKey, row.url().spec()); value->SetStringFromUTF16(keys::kTitleKey, row.title()); value->SetReal(keys::kLastVisitdKey, MilliSecondsFromTime(row.last_visit())); @@ -44,11 +44,11 @@ void AddHistoryNode(const history::URLRow& row, ListValue* list) { void GetVisitInfoDictionary(const history::VisitRow& row, DictionaryValue* value) { - value->SetString(keys::kIdKey, Int64ToString(row.url_id)); - value->SetString(keys::kVisitId, Int64ToString(row.visit_id)); + value->SetString(keys::kIdKey, base::Int64ToString(row.url_id)); + value->SetString(keys::kVisitId, base::Int64ToString(row.visit_id)); value->SetReal(keys::kVisitTime, MilliSecondsFromTime(row.visit_time)); value->SetString(keys::kReferringVisitId, - Int64ToString(row.referring_visit)); + base::Int64ToString(row.referring_visit)); const char* trans = PageTransition::CoreTransitionString(row.transition); DCHECK(trans) << "Invalid transition."; |