Add 3 tests for extension installation. Fix and re-enable UpdatePermissions test.

BUG=none
TEST=none
Review URL: http://codereview.chromium.org/547017

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36679 0039d316-1c4b-4281-b951-d872f2087c98

1 files changed, 14 insertions, 12 deletions

diff --git a/chrome/browser/extensions/extension_install_ui.h b/chrome/browser/extensions/extension_install_ui.h
index cda2076..dcf8cd9 100644
--- a/chrome/browser/extensions/extension_install_ui.h
+++ b/chrome/browser/extensions/extension_install_ui.h
@@ -48,31 +48,33 @@ class ExtensionInstallUI {
 
   explicit ExtensionInstallUI(Profile* profile);
 
+  virtual ~ExtensionInstallUI() {}
+
   // This is called by the installer to verify whether the installation should
-  // proceed.
+  // proceed. This is declared virtual for testing.
   //
   // We *MUST* eventually call either Proceed() or Abort()
   // on |delegate|.
-  void ConfirmInstall(Delegate* delegate, Extension* extension,
-                      SkBitmap* icon);
+  virtual void ConfirmInstall(Delegate* delegate, Extension* extension,
+                              SkBitmap* icon);
 
   // This is called by the extensions management page to verify whether the
-  // uninstallation should proceed.
+  // uninstallation should proceed. This is declared virtual for testing.
   //
   // We *MUST* eventually call either Proceed() or Abort()
   // on |delegate|.
-  void ConfirmUninstall(Delegate* delegate, Extension* extension,
-                        SkBitmap* icon);
+  virtual void ConfirmUninstall(Delegate* delegate, Extension* extension,
+                                SkBitmap* icon);
 
-  // Installation was successful.
-  void OnInstallSuccess(Extension* extension);
+  // Installation was successful. This is declared virtual for testing.
+  virtual void OnInstallSuccess(Extension* extension);
 
-  // Installation failed.
-  void OnInstallFailure(const std::string& error);
+  // Installation failed. This is declared virtual for testing.
+  virtual void OnInstallFailure(const std::string& error);
 
   // The install was rejected because the same extension/version is already
-  // installed.
-  void OnOverinstallAttempted(Extension* extension);
+  // installed. This is declared virtual for testing.
+  virtual void OnOverinstallAttempted(Extension* extension);
 
  private:
   // When a Theme is downloaded it is applied and an info bar is shown to give