diff options
author | mpcomplete@chromium.org <mpcomplete@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-06-24 17:49:08 +0000 |
---|---|---|
committer | mpcomplete@chromium.org <mpcomplete@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-06-24 17:49:08 +0000 |
commit | 05c82189519642144323493e1d0cd65c41ce81ce (patch) | |
tree | abb760e7c2d610ab059eec1222fc3d15b6b30db5 /chrome/browser/extensions/extension_startup_browsertest.cc | |
parent | eb40bc39aafb7933251450019e5b4bcb805982f5 (diff) | |
download | chromium_src-05c82189519642144323493e1d0cd65c41ce81ce.zip chromium_src-05c82189519642144323493e1d0cd65c41ce81ce.tar.gz chromium_src-05c82189519642144323493e1d0cd65c41ce81ce.tar.bz2 |
Require user opt-in before allowing content script injection on file URLs.
BUG=47180
Review URL: http://codereview.chromium.org/2809034
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50737 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/browser/extensions/extension_startup_browsertest.cc')
-rw-r--r-- | chrome/browser/extensions/extension_startup_browsertest.cc | 18 |
1 files changed, 18 insertions, 0 deletions
diff --git a/chrome/browser/extensions/extension_startup_browsertest.cc b/chrome/browser/extensions/extension_startup_browsertest.cc index ed62a40..7566caa 100644 --- a/chrome/browser/extensions/extension_startup_browsertest.cc +++ b/chrome/browser/extensions/extension_startup_browsertest.cc @@ -63,6 +63,7 @@ class ExtensionStartupTestBase : public InProcessBrowserTest { if (!load_extension_.value().empty()) { command_line->AppendSwitchWithValue(switches::kLoadExtension, load_extension_.ToWStringHack()); + command_line->AppendSwitch(switches::kDisableExtensionsFileAccessCheck); } } @@ -143,6 +144,23 @@ IN_PROC_BROWSER_TEST_F(ExtensionsStartupTest, Test) { TestInjection(true, true); } +// Tests that disallowing file access on an extension prevents it from injecting +// script into a page with a file URL. +IN_PROC_BROWSER_TEST_F(ExtensionsStartupTest, NoFileAccess) { + WaitForServicesToStart(4, true); // 1 component extension and 3 others. + + ExtensionsService* service = browser()->profile()->GetExtensionsService(); + for (size_t i = 0; i < service->extensions()->size(); ++i) { + if (service->AllowFileAccess(service->extensions()->at(i))) { + service->SetAllowFileAccess(service->extensions()->at(i), false); + ui_test_utils::WaitForNotification( + NotificationType::USER_SCRIPTS_UPDATED); + } + } + + TestInjection(false, false); +} + // ExtensionsLoadTest // Ensures that we can startup the browser with --load-extension and see them // run. |