diff options
| author | deepak.m1 <deepak.m1@samsung.com> | 2015-05-11 01:11:19 -0700 |
|---|---|---|
| committer | Commit bot <commit-bot@chromium.org> | 2015-05-11 08:11:49 +0000 |
| commit | 21895c01cffc939c13935599bb1bfc880e78453e (patch) | |
| tree | 8895d0ec27160049c0a59d406dc5678033b49093 /chrome/browser/extensions/extension_tab_util.cc | |
| parent | 492dc31b433656444c9c74213a133c19c8ebfa21 (diff) | |
| download | chromium_src-21895c01cffc939c13935599bb1bfc880e78453e.zip chromium_src-21895c01cffc939c13935599bb1bfc880e78453e.tar.gz chromium_src-21895c01cffc939c13935599bb1bfc880e78453e.tar.bz2 | |
Returning Corresponding Error Message when their is error in OpenTab.
This is for TODO for returning error message when error occurs in OpenTab().
BUG=485875
Review URL: https://codereview.chromium.org/1130373002
Cr-Commit-Position: refs/heads/master@{#329115}
Diffstat (limited to 'chrome/browser/extensions/extension_tab_util.cc')
| -rw-r--r-- | chrome/browser/extensions/extension_tab_util.cc | 8 |
1 files changed, 6 insertions, 2 deletions
diff --git a/chrome/browser/extensions/extension_tab_util.cc b/chrome/browser/extensions/extension_tab_util.cc index 706f41e..f1783f7 100644 --- a/chrome/browser/extensions/extension_tab_util.cc +++ b/chrome/browser/extensions/extension_tab_util.cc @@ -143,7 +143,8 @@ base::DictionaryValue* ExtensionTabUtil::OpenTab( browser->host_desktop_type()); if (!browser || !browser->window()) { - // TODO(rpaquay): Error message? + if (error) + *error = keys::kNoCurrentWindowError; return NULL; } @@ -160,7 +161,10 @@ base::DictionaryValue* ExtensionTabUtil::OpenTab( NULL, &opener, NULL)) { - // TODO(rpaquay): Error message? + if (error) { + *error = ErrorUtils::FormatErrorMessage(keys::kTabNotFoundError, + base::IntToString(opener_id)); + } return NULL; } } |